Add fix for reference URL calculation and add/change coresponding tests #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the used JSON node for TLP Label from `/csaf/document/distribution/tlp` to `/csaf/document/distribution/tlp/label` and lowercase the label in `calculateReferenceUrl`. This assures that the generated URL contains the correct label and is consistant with the document tree setup by CSAF Publisher. The `setFinalTrackingIdTest` is changed accoding to the lowercase change and a new `setFinalTrackingIdTest_label_not_null` test is added to test the correct usage of a given label.
Contributor
|
belongs to: #202 |
rainer-exxcellent
requested changes
Apr 7, 2025
src/test/java/de/bsi/secvisogram/csaf_cms_backend/json/AdvisoryWrapperTest.java
Outdated
Show resolved
Hide resolved
rainer-exxcellent
requested changes
Apr 9, 2025
src/test/java/de/bsi/secvisogram/csaf_cms_backend/json/AdvisoryWrapperTest.java
Outdated
Show resolved
Hide resolved
Add a missing "/". Co-authored-by: Rainer Schneider <[email protected]>
rainer-exxcellent
approved these changes
Apr 9, 2025
Contributor
rainer-exxcellent
left a comment
rainer-exxcellent
left a comment
There was a problem hiding this comment.
Now it looks good to me
mfd2007
approved these changes
May 2, 2025
mfd2007
pushed a commit
that referenced
this pull request
Nov 18, 2025
mfd2007
pushed a commit
that referenced
this pull request
Nov 18, 2025
Add a missing "/". Co-authored-by: Rainer Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the used JSON node for TLP Label from
/csaf/document/distribution/tlpto/csaf/document/distribution/tlp/labeland lowercase the label incalculateReferenceUrl. This assures that the generated URL contains the correct label and is consistant with the document tree setup by CSAF Publisher.The
setFinalTrackingIdTestis changed accoding to the lowercase change and a newsetFinalTrackingIdTest_label_not_nulltest is added to test the correct usage of a given label.