Skip to content

feat: ✨ add reusable-test-copier workflow#294

Merged
lwjohnst86 merged 2 commits intomainfrom
feat/test-copier
Aug 24, 2025
Merged

feat: ✨ add reusable-test-copier workflow#294
lwjohnst86 merged 2 commits intomainfrom
feat/test-copier

Conversation

@martonvago
Copy link
Contributor

Description

This PR adds a reusable-test-copier workflow. Copied from https://github.com/seedcase-project/template-website/blob/main/.github/workflows/test.yml

This PR needs a medium-depth review.

@martonvago martonvago self-assigned this Aug 19, 2025
@martonvago martonvago moved this from Todo to In Review in Product development Aug 19, 2025
@martonvago martonvago removed this from Roadmap Aug 19, 2025
@martonvago martonvago requested review from a team and removed request for a team August 19, 2025 10:18
Comment on lines +16 to +17
- name: Set up Quarto
uses: quarto-dev/quarto-actions/setup@9e48da27e184aa238fcb49f5db75469626d43adb # v2.1.9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all templates need Quarto -- should this be conditional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, good point! Yea, having an input arg in workflow_call for it would be awesome!

@martonvago martonvago marked this pull request as ready for review August 19, 2025 10:23
@martonvago martonvago requested a review from a team as a code owner August 19, 2025 10:23
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a conditional for Quarto and otherwise looks nice!

Comment on lines +16 to +17
- name: Set up Quarto
uses: quarto-dev/quarto-actions/setup@9e48da27e184aa238fcb49f5db75469626d43adb # v2.1.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, good point! Yea, having an input arg in workflow_call for it would be awesome!

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Product development Aug 20, 2025
lwjohnst86 added a commit to seedcase-project/template-data-package that referenced this pull request Aug 20, 2025
# Description

This PR switches over to the `reusable-test-copier` workflow.
Depends on seedcase-project/.github#294 and #150

Closes #65 

This PR needs a quick review.

## Checklist

- [x] Formatted Markdown
- [x] Ran `just run-all`

Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
@martonvago
Copy link
Contributor Author

I hope I added it correctly 🤞

@martonvago martonvago requested a review from lwjohnst86 August 20, 2025 13:04
@martonvago martonvago moved this from In Progress to In Review in Product development Aug 20, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Product development Aug 24, 2025
@lwjohnst86 lwjohnst86 merged commit c35b202 into main Aug 24, 2025
3 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/test-copier branch August 24, 2025 07:12
@github-project-automation github-project-automation bot moved this from In Progress to Done in Product development Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants