Skip to content

docs: 🏗️ explain about using Sprout read_properties()#103

Open
lwjohnst86 wants to merge 5 commits intomainfrom
docs/integrate-use-of-sprout-read-properties
Open

docs: 🏗️ explain about using Sprout read_properties()#103
lwjohnst86 wants to merge 5 commits intomainfrom
docs/integrate-use-of-sprout-read-properties

Conversation

@lwjohnst86
Copy link
Member

Description

To make reading in the properties more standardized and allow better type checking etc.

Closes #94

Needs a thorough review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner February 9, 2026 17:31
@lwjohnst86 lwjohnst86 moved this from Todo to In Review in Iteration planning Feb 9, 2026
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor suggestions:

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Feb 10, 2026
lwjohnst86 and others added 2 commits February 10, 2026 12:09
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
@lwjohnst86 lwjohnst86 requested a review from signekb February 10, 2026 11:10
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Iteration planning Feb 10, 2026
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs formatting, otherwise 👍

Comment on lines +41 to +42
file through the `read_properties()` function from [Sprout](https://sprout.seedcase-project.org)
, which returns a `PackageProperties` object. This is a Python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file through the `read_properties()` function from [Sprout](https://sprout.seedcase-project.org)
, which returns a `PackageProperties` object. This is a Python
file through the `read_properties()` function from [Sprout](https://sprout.seedcase-project.org),
which returns a `PackageProperties` object. This is a Python

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Update design to say we import properties via Sprout and that they are checked

3 participants