-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ beautify CLI help message #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joelostblom
wants to merge
20
commits into
main
Choose a base branch
from
feat/beautify-cli-help
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
−24
Open
Changes from 7 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8986e2f
feat: :sparkles: Include several approaches of improving the CLI
joelostblom ef2a603
fix: :bug: Clean up to only keep the current suggestion
joelostblom 52882f5
feat: :sparkles: Show default value also for `None`
joelostblom c9251ff
refactor: :recycle: Use functional style
joelostblom 314dbff
docs: :memo: Explain need for sorting
joelostblom 8df5e66
test: :white_check_mark: Avoid testing private modules
joelostblom a5ea441
Merge branch 'main' into feat/beautify-cli-help
lwjohnst86 4360ed7
Apply suggestions from code review
joelostblom 824bdd7
chore(pre-commit): :pencil2: automatic fixes
pre-commit-ci[bot] bb4c41d
test: :white_check_mark: Remove coverage config
joelostblom b5ae897
fix: :bug: Uuse more descriptive variable name
joelostblom f4c70c2
Merge branch 'main' into feat/beautify-cli-help
lwjohnst86 206d742
Apply suggestion from @joelostblom
joelostblom 7d94a3a
Merge branch 'main' into feat/beautify-cli-help
lwjohnst86 ad65ac8
docs: 📝 Reformat as per just run all
joelostblom 775eeae
Merge branch 'main' into feat/beautify-cli-help
joelostblom 4aff1f8
test: ✅ Reformat test strings to match new help format
joelostblom 79cfe34
test: ✅ Test color output in help message
joelostblom 5e1f4f3
chore(pre-commit): :pencil2: automatic fixes
pre-commit-ci[bot] 87f1a1a
chore: 🔧 Restore unintended formatting changes
joelostblom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [run] | ||
| omit = src/seedcase_flower/internals.py | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This excludes our private code from the coverage percentage. I remember we mentioned before that we only test public facing code (and implicitly the private code as it is used in the public facing code). I don't know if we want it formal through a change like this but I'm including it as a suggestion since this PR fails coverage without it (could be made its own PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand. Is that because the code you're adding isn't used when running via tests, so doesn't get picked up by the coverage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm unsure how to test this since there is no public function calling this code. It is only used during the initialization of
app, should we create a test forapp --helpwhich compares the output help string to a fixed test case? It seems a bit wonky, but that the public facing component is correct formatting of the help message.It would be easier to test the private function directly, but then there could be a gap to what we think is the correct behavior and what actually makes the help message look the way it should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I think for now, it's fine to keep it in the coverage percent. It truthfully shows that not all code has been covered, which is true! 😛 So you can delete this file☺️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, removed!