-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ _parse_uri()
#152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+197
−33
Merged
feat: ✨ _parse_uri()
#152
Changes from 14 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
5f6fae2
feat: :sparkles: Move over relevant code from sprout and cdp
joelostblom 6f0ef5d
feat: :sparkles: Add Https type and class validator
joelostblom f943218
feat: :sparkles: Implement resolve_uri
joelostblom a89633d
refactor: ♻️ Use case/match for readabilty
joelostblom 8072033
refactor: ♻️ Make variable names more precise
joelostblom 7763097
fix: 🐛 Remove unnused import
joelostblom c375a30
fix: 🐛 Fix mypy errors
joelostblom 26ad174
chore: 🔧 Fix typing
joelostblom 662c3d6
fix: 🐛 Remove old tmp code
joelostblom fd70520
fix: 🐛 Remove unused import
joelostblom b7ad9a0
fix: 🐛 Pass vulture checks
joelostblom df338f3
test: ✅ Comment code to be updated in separate PR to pass tests
joelostblom 0044b9c
fix: 🐛 Remove check datapacakge from this PR
joelostblom 05fbaa8
fix: 🐛 Create type alias
joelostblom 5aae406
fix: 🐛 Ignore line in mypy instead of changing logic
joelostblom ae6c6eb
refactor: ♻️ Change pydantic classes to custom dataclass
joelostblom f88fb14
fix: 🐛 Name parameters more precisely
joelostblom 4b632fd
fix: 🐛 Remove explicit file exist check
joelostblom 95b9c69
refactor: ♻️ Reduce cases
joelostblom 4005455
refactor: ♻️ Name variables more precisely
joelostblom 78da642
docs: 📝 Clarify what source can be
joelostblom c1bcb3f
fix: 🐛 Avoid changes to read_properties in this PR
joelostblom 2b5aeea
Revert "fix: 🐛 Avoid changes to read_properties in this PR"
joelostblom 43a974e
feat: ✨ Check types
joelostblom 39a8c76
fix: 🐛 Remove redundant parsin of gh uri
joelostblom 3c091bf
feat: ✨ Improve naming
joelostblom 030789e
feat: ✨ Add read_prop skeleton
joelostblom fd8c748
refactor: ♻️ Revert to less precise name until we have discussed more
joelostblom 0b5d5d6
Merge branch 'main' into feat/resolve-uri
joelostblom 6a12807
test: ✅ Update test to match new docstring
joelostblom 7d1b019
fix: 🐛 Restore local file reading behavior to not break former test
joelostblom a5cc597
refactor: ♻️ Rename test function to match refactor
joelostblom d2fb845
chore: 🔧 Ignore mypy on lines to be fixed in read_prop PR
joelostblom f5a206c
test: ✅ Add internal tests for _parse_uri
joelostblom 115b19e
build: 🔨 uv update
joelostblom 779f627
Potential fix for code scanning alert no. 14: Incomplete URL substrin…
joelostblom 539af8e
Apply suggestions from code review
joelostblom 19a145e
test: ✅ Parameterize github tests for clarity
joelostblom 64696a1
docs: 📝 Reformat docstring to fit width
joelostblom d53e619
test: ✅ Update help message constant
joelostblom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.