Merged
Conversation
saibotk
requested changes
Apr 5, 2025
Member
saibotk
left a comment
saibotk
left a comment
There was a problem hiding this comment.
Glad you enjoyed it 🫶
And thanks so much for the contribution. Amazing to see new research here.
Left some questions and minor renaming suggestions 👍
mpass99
force-pushed
the
feature/cell-info-types
branch
from
74c4f5f to
dae15cf
Compare
mpass99
force-pushed
the
feature/cell-info-types
branch
from
dae15cf to
51ac46a
Compare
saibotk
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aristoteles has a great structure! Really nice to add new TLV parsers 🙌
Here are some parsers for the cell info types we analysed and use for seemoo-lab/CellGuard.