Add Generated Direction Header#14
Merged
saibotk merged 1 commit intoseemoo-lab:masterfrom Jul 18, 2025
Merged
Conversation
mpass99
force-pushed
the
feature/direction
branch
from
fe53829 to
ae7c302
Compare
saibotk
approved these changes
Jul 18, 2025
Member
saibotk
left a comment
saibotk
left a comment
There was a problem hiding this comment.
Amazing :) And thanks for contributing these improvements, always happy to see them!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst researching with Aristoteles again (it's of ongoing great use! :), I felt the need to filter by packet direction - aka if the packet is going from the main processor to the baseband (OUT) or from the baseband to the processor (IN).
Different from QMI, ARI packets do not include the direction within the packet itself. However, we can often derive the direction from the message name. In 89% of the messages, the name ends with
Req,Resp,RespCb,Rsp,RspCb,Ind, orIndCb. With some additional pattern-matching tweaks, we can increase the performance to 95% of all message types.