Show mic muted toast with optimizations service running #3534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seerge
force-pushed
the
main
branch
2 times, most recently
from
034cc5f to
f742d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if ASUS optimizations service is running, there's no toast or anything to show that you muted or unmuted microphone.
I believe this is because optimization services handle muting microphone, and so g-helper shouldn't do it itself, which is reasonable. The problem is that optimization services don't create toasts for it.
These changes should keep existing behavior that if optimization service is running, g-helper doesn't mute the microphone, but will show a toast and change LED indicator to show that microphone is indeed muted.