-
-
Notifications
You must be signed in to change notification settings - Fork 548
fix(ui): remove duplicate download items in manage slide over #1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): remove duplicate download items in manage slide over #1916
Conversation
a0e341c to
15196c4
Compare
15196c4 to
16aaf5d
Compare
gauthier-th
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce your issue in the first place.
This is something #927 should already have fixed. How are you items downloaded?
|
It's almost like #927, but not in the same location: my PR is for the "Manage series", not the "Status Badge" To reproduce, simply download a torrent for an entire season and go to "Manage Series". This is a test a just did on develop branch, without my PR : The status badge only shows one download: But in "Manage Series," I have the same download ten times (I also tried with a season of 8 episodes and it only shows 8 times the download so I think it take only the 10 firsts downloads of a TV show) : |
|
Ah, I didn't see I forgot to implement it there too. Could you please implement the same logic as I did on the #927 PR? |
|
This PR is stale because it has been open 30 days with no activity. Please address the feedback or provide an update to keep it open. |
|
This PR was closed because it has been stalled for 30 days with no activity. You can reopen it once you address the feedback or provide the requested changes. |
|
Re-opening this since it's an interesting QOL feature. |
@InterN0te any update? |
Apply the same logic as PR #927 to deduplicate season pack downloads in the "Manage Series" slide-over panel.
e014c4b to
99ea525
Compare
|
Hi @gauthier-th @fallenbagel ! Sorry for the delay. I've updated the PR to use the same logic as #927 - filtering by This is consistent with your approach in #927 and should be cleaner than the previous title-based filtering. Let me know if you'd like any changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes duplicate download items appearing in the manage slide over UI by filtering based on unique downloadId values. The implementation prevents the same download from being displayed multiple times, improving UI clarity.
Key Changes:
- Added
filterDuplicateDownloadshelper function that deduplicates download items bydownloadId - Applied filtering to both regular and 4K download status lists
- Enhanced key prop differentiation for 4K items by adding
-4k-prefix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Gauthier <[email protected]>




Description
Prevents duplicate download items from being displayed by filtering based on title uniqueness. This improves UI clarity when the same content appears multiple times in the download status.
Summary
getUniqueByTitlefunction to filter duplicate download items based on titleScreenshot
Before
After
Test plan