feat(sidebar): Added watchlist link to sidebar#2751
feat(sidebar): Added watchlist link to sidebar#2751OnePoncho wants to merge 7 commits intoseerr-team:developfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded a "Watchlist" navigation link at Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/Layout/Sidebar/index.tsx`:
- Line 30: The translation key "watchlist" is defined in the Sidebar locale
object (watchlist: 'Watchlist' in src/components/Layout/Sidebar/index.tsx) but
not present in the locale files; run the extraction and update locales by
running the i18n extractor (pnpm i18n:extract) to add "watchlist" to
src/i18n/locale/en.json (and other locale files), or manually add the
"watchlist" key with the appropriate string to each locale so the translation
system finds it instead of relying on the inline fallback.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 98566109-ce15-4000-89ee-6f763e081656
📒 Files selected for processing (1)
src/components/Layout/Sidebar/index.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/Layout/Sidebar/index.tsx`:
- Around line 77-82: Add the missing watchlist menu entry to the MobileMenu's
menuLinks array in src/components/Layout/MobileMenu/index.tsx: insert an object
matching the Sidebar entry with href: '/discover/watchlist', messagesKey:
'watchlist', svgIcon: <BookmarkIcon ...> (use the same BookmarkIcon import used
elsewhere), and the same activeRegExp (e.g. /^\/discover\/watchlist$/) so mobile
and desktop navigation are consistent; ensure BookmarkIcon is imported in
MobileMenu if not already and follow existing menuLinks formatting.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 13cc5b52-7864-4f68-8e15-d48ac1203ddc
📒 Files selected for processing (1)
src/components/Layout/Sidebar/index.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/Layout/MobileMenu/index.tsx`:
- Around line 97-103: The watchlist menu item (object with href
'/discover/watchlist' and activeRegExp /^\/discover\/watchlist$/) is inserted
before the Requests entry which shifts filteredLinks and causes the fixed-bar
slice logic to drop the '/requests' link for privileged users; either move that
watchlist object to after the Requests entry in the menu array or modify the
filteredLinks/fixed-bar selection logic (the slice that builds the fixed mobile
bar) to always include the link with href '/requests' for admin/mod roles (e.g.,
detect user role and unshift or ensure '/requests' is present in the first N
fixedBarLinks) so the Requests item and its badge remain visible.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 546b7d4a-a5b1-4b8b-a09d-4929e8ef8905
📒 Files selected for processing (1)
src/components/Layout/MobileMenu/index.tsx
Description
Added a link to watchlist in the sidebar for easier navigation to watchlist when in any other page but /discover.
How Has This Been Tested?
Watchlist population and depopulation with the original link on the discover page as well as the new sidebar link.
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit