Skip to content

fix(helm): configure liveness and readiness probes to match Docker defaults#2755

Open
Jyasapara wants to merge 1 commit intoseerr-team:developfrom
Jyasapara:fix-helm-chart-liveness-readiness-probes
Open

fix(helm): configure liveness and readiness probes to match Docker defaults#2755
Jyasapara wants to merge 1 commit intoseerr-team:developfrom
Jyasapara:fix-helm-chart-liveness-readiness-probes

Conversation

@Jyasapara
Copy link
Copy Markdown

@Jyasapara Jyasapara commented Mar 23, 2026

Description

Switches liveness and readiness endpoint to /api/v1/status to avoid unnecessary redirect chains and reduce load/noise, matching the documented docker healthcheck.

Set sensible default probe values in values.yaml to match the docker documentation defaults:
livenessProbe: initialDelaySeconds=20, periodSeconds=15, timeoutSeconds=3
readinessProbe: initialDelaySeconds=60, periodSeconds=15, timeoutSeconds=3

How Has This Been Tested?

Rolled out the chart in my k8s cluster.

Screenshots / Logs (if applicable)

image

Rollout around 21:45.

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Summary by CodeRabbit

  • Chores
    • Updated Helm chart to version 3.3.1 with improved health probe configuration.
    • Configured explicit timing parameters for liveness and readiness probes to enhance deployment reliability.
    • Updated probe endpoints for more accurate health status monitoring.

Switches liveness and readiness endpoint to `/api/v1/status` to avoid
unnecessary redirect chains and reduce load/noise, matching the
documented docker healthcheck.

Set sensible default probe values in values.yaml to match the docker
documentation defaults:
- livenessProbe: initialDelaySeconds=20, periodSeconds=15, timeoutSeconds=3
- readinessProbe: initialDelaySeconds=60, periodSeconds=15, timeoutSeconds=3

Fixes seerr-team#2754
@Jyasapara Jyasapara requested a review from a team as a code owner March 23, 2026 21:07
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

📝 Walkthrough

Walkthrough

This PR updates the Seerr Helm chart from version 3.3.0 to 3.3.1, changing health check probe endpoints from / to /api/v1/status and configuring explicit timing parameters (initialDelaySeconds, periodSeconds, timeoutSeconds) to align with the Docker deployment documentation recommendations.

Changes

Cohort / File(s) Summary
Chart Metadata
charts/seerr-chart/Chart.yaml
Bumped Helm chart version from 3.3.0 to 3.3.1.
Health Check Configuration
charts/seerr-chart/values.yaml, charts/seerr-chart/templates/statefulset.yaml
Updated livenessProbe and readinessProbe endpoints from / to /api/v1/status; added explicit timing parameters (initialDelaySeconds: 20, periodSeconds: 15, timeoutSeconds: 3) to values.yaml defaults to replace empty objects.
Documentation
charts/seerr-chart/README.md
Updated version badge and documented new default probe timing configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • #2597: Modifies same Helm chart metadata files for version bumping and documentation updates.
  • #2441: Similar chart version bump pattern in charts/seerr-chart/Chart.yaml.

Suggested reviewers

  • fallenbagel
  • 0xSysR3ll
  • sudo-kraken

Poem

🐰 Health checks now align, from Docker to Helm so bright,
/api/v1/status queries in the night,
Timings configured, no more / redirect confusion,
Chart version bumped with thoughtful precision! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR addresses all core coding requirements from issue #2754: changed probe endpoints to /api/v1/status, set default probe timing values (livenessProbe: 20/15/3, readinessProbe: 60/15/3), and eliminated empty probe configurations.
Out of Scope Changes check ✅ Passed All changes are directly within scope of issue #2754: probe endpoint updates, default probe timing values, and Chart.yaml version bump. No unrelated modifications detected.
Title check ✅ Passed The title clearly and concisely summarizes the main change: configuring liveness and readiness probes in the Helm chart to match Docker defaults, which is the primary objective of this PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@M0NsTeRRR M0NsTeRRR enabled auto-merge (squash) March 23, 2026 23:13
@M0NsTeRRR M0NsTeRRR changed the title fix: helm chart liveness and readiness probe fix(helm): configure liveness and readiness probes to match Docker defaults Mar 23, 2026
@fallenbagel fallenbagel added this to the v3.2.0 milestone Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align health checks in helm chart with docs for docker

3 participants