Skip to content

Conversation

nk1107
Copy link
Contributor

@nk1107 nk1107 commented Jul 21, 2025

This change adds SFTP credential validations for the AudienceEnteredSFTP action for actions-liveramp-audiences

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.82%. Comparing base (fc0c26e) to head (65188f6).
⚠️ Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
...ns/liveramp-audiences/audienceEnteredSftp/index.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3098      +/-   ##
==========================================
+ Coverage   79.65%   79.82%   +0.16%     
==========================================
  Files        1133     1165      +32     
  Lines       21026    21512     +486     
  Branches     4070     4154      +84     
==========================================
+ Hits        16749    17172     +423     
- Misses       3577     3626      +49     
- Partials      700      714      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants