-
Notifications
You must be signed in to change notification settings - Fork 282
[algolia-insights] add support for auth user token and product list viewed #3104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[algolia-insights] add support for auth user token and product list viewed #3104
Conversation
Thanks for the PR @jkaho . I'll schedule time to review. |
Hi @jkaho I had a quick scan. Did you mean to include the file at this location? packages/browser-destinations/destinations/algolia-plugins/src/algoliaInsights/generated-types.ts |
Thanks @joe-ayoub-segment! Sorry, I missed that–no I did not mean to include it. Removed 👍 |
objectIDs: { | ||
label: 'Product IDs', | ||
description: 'Product IDs of the viewed items. Defaults to an array of `products.product_id`.', | ||
type: 'string', | ||
multiple: true, | ||
required: true, | ||
default: { | ||
'@arrayPath': ['$.properties.products', { '@path': '$.product_id' }] | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jkaho I'm not sure if this is going to work.
I've never tested a default mapping which uses arrayPath on a string field.
Did you try testing this locally?
Hi @jkaho please run this command and commit the changes
|
Hi again @jkaho , I reviewed the PR. Regarding adding the new field
Regarding the new Action:
Best regards, |
hi again @jkaho can you please also run |
Hey @joe-ayoub-segment, appreciate the review!
![]() |
Add support for the Algolia Insights API optional
authenticatedUserToken
field.Add support for the Segment
Product List Viewed
event.Related doc change: segmentio/segment-docs#7791
Testing