Skip to content

Conversation

kc-ong-taguchi
Copy link

@kc-ong-taguchi kc-ong-taguchi commented Aug 5, 2025

A summary of your pull request, including the what change you're making and why.

  • Added new action syncEvent to sync all event related to the audiences data

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment
Copy link
Contributor

Hi @kc-ong-taguchi thanks for the PR.
Looks like the PR made changes to files other than the Taguchi files.
Could you correct this please?

@kc-ong-taguchi
Copy link
Author

kc-ong-taguchi commented Aug 5, 2025 via email

@joe-ayoub-segment
Copy link
Contributor

Hi @kc-ong-taguchi I've updated the branch from main.

@joe-ayoub-segment
Copy link
Contributor

Hi @kc-ong-taguchi - that didn't seem to work.
Instead, why don't you just take the folder for the taguchi Destination from your branch, and raise a new PR onto the main Segment branch?

@joe-ayoub-segment
Copy link
Contributor

I'll close this PR for now.

@kc-ong-taguchi
Copy link
Author

kc-ong-taguchi commented Aug 6, 2025

Hi @joe-ayoub-segment, the commits look good and clean now.

@kc-ong-taguchi
Copy link
Author

Hi @joe-ayoub-segment , any update on when this PR will be merged?

type: 'number',
required: false
},
products: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kc-ong-taguchi ,

can we move products into its own field please?
products is an object array field, so will not render correctly if contained within another object field.

Thanks,
Joe

@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Aug 25, 2025 via email

@joe-ayoub-segment
Copy link
Contributor

Replaced with this PR #3139

I'll deploy on Tuesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants