Skip to content

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Aug 12, 2025

This PR upgrades the Facebook Custom Audiences destination from Facebook Graph API v21.0 to v23.0 as requested in the issue.

Changes Made

Updated the API version constants in packages/destination-actions/src/destinations/facebook-custom-audiences/constants.ts:

  • API_VERSION: 'v21.0''v23.0'
  • CANARY_API_VERSION: 'v21.0''v23.0'

Testing

All existing tests continue to pass (61 tests total), confirming that:

  • The upgrade maintains backward compatibility
  • Both default and canary API version scenarios work correctly
  • All Facebook Graph API endpoints now use v23.0
  • No breaking changes were introduced

The destination's existing functionality remains intact while now utilizing the newer Facebook Graph API version.

Fixes #3168.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • formulae.brew.sh
    • Triggering command: /bin/curl -q --fail --compressed --silent --speed-limit 100 --speed-time 5 --location --remote-time --output /home/REDACTED/.cache/Homebrew/api/formula.jws.json --user-agent Linuxbrew/4.6.3 (Linux; x86_64 Ubuntu 24.04.2 LTS) curl/8.5.0 REDACTED (dns block)
    • Triggering command: /bin/curl -q --fail --compressed --silent --speed-limit 100 --speed-time 5 --location --remote-time --output /home/REDACTED/.cache/Homebrew/api/cask.jws.json --user-agent Linuxbrew/4.6.3 (Linux; x86_64 Ubuntu 24.04.2 LTS) curl/8.5.0 REDACTED (dns block)
    • Triggering command: /bin/curl -q --fail --compressed --silent --speed-limit 100 --speed-time 5 --location --remote-time --output /home/REDACTED/.cache/Homebrew/api/formula_tap_migrations.jws.json --user-agent Linuxbrew/4.6.3 (Linux; x86_64 Ubuntu 24.04.2 LTS) curl/8.5.0 REDACTED (dns block)
  • https://api.github.com/repos/Homebrew/brew/tags
    • Triggering command: /bin/curl -q --silent --max-time 3 --location --no-remote-time --output /dev/null --write-out %{http_code} --dump-header /home/linuxbrew/.linuxbrew/Homebrew/.git/GITHUB_HEADERS --user-agent Linuxbrew/4.6.3 (Linux; x86_64 Ubuntu 24.04.2 LTS) curl/8.5.0 --header X-GitHub-Api-Version:2022-11-28 --header Accept: application/vnd.github+json --header If-None-Match: "" REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Upgrade facebook-custom-audiences to vv23.0 Upgrade facebook-custom-audiences to Facebook Graph API v23.0 Aug 12, 2025
Copilot finished work on behalf of abhandage August 12, 2025 09:54
@Copilot Copilot AI requested a review from abhandage August 12, 2025 09:54
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.81%. Comparing base (a10053a) to head (76293e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3169   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files        1165     1165           
  Lines       21513    21513           
  Branches     4159     4159           
=======================================
  Hits        17171    17171           
  Misses       3627     3627           
  Partials      715      715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade facebook-custom-audiences to vv23.0
3 participants