Skip to content

Conversation

Vanessa-SSY
Copy link
Contributor

@Vanessa-SSY Vanessa-SSY commented Aug 13, 2025

A summary of your pull request, including the what change you're making and why.

The Graphql request was improperly formatted and caused error: "Expected NAME, actual: UNKNOWN_CHAR ("") at [17, 30]". Fixing the format and tested.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.
Screenshot 2025-08-13 at 6 02 20 PM Also checked in stackadapt API server logs and confirm that the request was successful.

@joe-ayoub-segment
Copy link
Contributor

Thanks for the PR @Vanessa-SSY . Was this issue introduced recently or has it been around for a while?
The PR looks good to me, but I'm relying on you to have tested it properly.

@Vanessa-SSY
Copy link
Contributor Author

Thanks for the PR @Vanessa-SSY . Was this issue introduced recently or has it been around for a while? The PR looks good to me, but I'm relying on you to have tested it properly.

It seems to be a legacy issue. We just have the internal service for processing profiles ready so back then nothing was processed. The change in this PR has been tested and I can confirm that the API service did receive the request and was able to process it.
QQ: would you be able to do a hotfix deploy since I wish to start end-to-end testing asap. Thanks! @joe-ayoub-segment

@joe-ayoub-segment
Copy link
Contributor

Hi @Vanessa-SSY I won't be able to deploy until next week.
There seems to be a linting issue too.

/home/runner/work/action-destinations/action-destinations/packages/destination-actions/src/destinations/stackadapt-audiences/functions.ts
Error: 76:7 error 'jsonString' is never reassigned. Use 'const' instead prefer-const
Warning: 88:13 warning Unsafe call of an any typed value @typescript-eslint/no-unsafe-call

Looks like you need to change the jsonString to be a const.

@Vanessa-SSY
Copy link
Contributor Author

Hi @Vanessa-SSY I won't be able to deploy until next week. There seems to be a linting issue too.

/home/runner/work/action-destinations/action-destinations/packages/destination-actions/src/destinations/stackadapt-audiences/functions.ts Error: 76:7 error 'jsonString' is never reassigned. Use 'const' instead prefer-const Warning: 88:13 warning Unsafe call of an any typed value @typescript-eslint/no-unsafe-call

Looks like you need to change the jsonString to be a const.

Fixed. May I know the earliest time you could help deploy next week?

@joe-ayoub-segment
Copy link
Contributor

Hi @Vanessa-SSY I won't be able to deploy until next week. There seems to be a linting issue too.
/home/runner/work/action-destinations/action-destinations/packages/destination-actions/src/destinations/stackadapt-audiences/functions.ts Error: 76:7 error 'jsonString' is never reassigned. Use 'const' instead prefer-const Warning: 88:13 warning Unsafe call of an any typed value @typescript-eslint/no-unsafe-call
Looks like you need to change the jsonString to be a const.

Fixed. May I know the earliest time you could help deploy next week?

Hi @Vanessa-SSY - most likely Tuesday.

@joe-ayoub-segment joe-ayoub-segment merged commit 59c6df5 into segmentio:main Aug 19, 2025
11 of 12 checks passed
@joe-ayoub-segment
Copy link
Contributor

Hi @Vanessa-SSY - PR deployed. Please confirm you are happy with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants