Skip to content

Conversation

abhandage
Copy link
Contributor

Currently when I am running the tests after upgrading dependencies in integrations I am facing below error

  ✖ No tests found in Service/service.test.js

  ─

  Uncaught exception in Service/service.test.js

  Error: Cannot find module '@aws-sdk/client-sts'
  Require stack:
  - /Users/abhandage/GitHub/segmentio/integrations/node_modules/@segment/action-destinations/dist/destinations/aws-s3/syncAudienceToCSV/s3.js
  - /Users/abhandage/GitHub/segmentio/integrations/node_modules/@segment/action-destinations/dist/destinations/aws-s3/syncAudienceToCSV/index.js
  - /Users/abhandage/GitHub/segmentio/integrations/node_modules/@segment/action-destinations/dist/destinations/aws-s3/index.js
  - /Users/abhandage/GitHub/segmentio/integrations/node_modules/@segment/action-destinations/dist/destinations/index.js
  - /Users/abhandage/GitHub/segmentio/integrations/node_modules/@segment/action-destinations/dist/index.js
  - /Users/abhandage/GitHub/segmentio/integrations/integrations/index.js
  - /Users/abhandage/GitHub/segmentio/integrations/Service/index.js
  - /Users/abhandage/GitHub/segmentio/integrations/Service/service.test.js
  - /Users/abhandage/GitHub/segmentio/integrations/node_modules/ava/lib/worker/subprocess.js

Because @aws-sdk/client-sts has not been added as a directly dependency in actions-destinations.

Hence adding it here.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@abhandage abhandage force-pushed the SECOPS-16392/add-dependencies branch from 1376400 to df30ab9 Compare August 14, 2025 11:27
@abhandage abhandage marked this pull request as ready for review August 14, 2025 11:33
@itsarijitray itsarijitray requested a review from Copilot August 14, 2025 11:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a missing dependency issue by adding @aws-sdk/client-sts as a direct dependency to fix module resolution errors in tests. The AWS STS client is being used in the AWS S3 destination but was not declared as a dependency, causing runtime errors when other packages try to import the action-destinations library.

Key Changes

  • Added @aws-sdk/client-sts version 3.614.0 to the package.json dependencies

@abhandage abhandage self-assigned this Aug 26, 2025
@joe-ayoub-segment joe-ayoub-segment merged commit 300a848 into main Aug 26, 2025
14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the SECOPS-16392/add-dependencies branch August 26, 2025 08:53
@joe-ayoub-segment
Copy link
Contributor

PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants