Skip to content

Conversation

varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented Aug 14, 2025

This pull request adds a publishConfig section to the package.json files for several browser destinations and the browser destination template. This change ensures that these packages are published publicly to the npm registry.

Publishing configuration updates:

  • Added publishConfig with "access": "public" and the npm registry URL to packages/browser-destinations/destinations/evolv-ai/package.json to enable public publishing.
  • Added publishConfig with "access": "public" and the npm registry URL to packages/browser-destinations/destinations/facebook-conversions-api-web/package.json to enable public publishing.
  • Added publishConfig with "access": "public" and the npm registry URL to the browser destination template in packages/cli/templates/destinations/browser/package.json, ensuring new destinations use the correct publish settings.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@varadarajan-tw varadarajan-tw requested review from a team as code owners August 14, 2025 16:06
@varadarajan-tw varadarajan-tw changed the title Mark some web destination packages as public Marks newere packages as public packages Aug 14, 2025
@varadarajan-tw varadarajan-tw changed the title Marks newere packages as public packages Marks newer browser destination packages as public packages Aug 14, 2025
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.57%. Comparing base (5357349) to head (198b453).

❌ Your project check has failed because the head coverage (32.57%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3183       +/-   ##
===========================================
- Coverage   79.76%   32.57%   -47.20%     
===========================================
  Files        1176       14     -1162     
  Lines       21643      703    -20940     
  Branches     4205      118     -4087     
===========================================
- Hits        17264      229    -17035     
+ Misses       3639      474     -3165     
+ Partials      740        0      -740     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joe-ayoub-segment
Copy link
Contributor

Please label for deploy when you want this to go out @varadarajan-tw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants