Skip to content

Conversation

varadarajan-tw
Copy link
Contributor

  • Add comprehensive structure and organization
  • Include specific guidance for different destination types
  • Add recommendations for feature flags on critical destinations
  • Improve PR review guidelines
  • Add detailed implementation best practices

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

- Add comprehensive structure and organization
- Include specific guidance for different destination types
- Add recommendations for feature flags on critical destinations
- Improve PR review guidelines
- Add detailed implementation best practices

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR significantly enhances the GitHub Copilot instructions to provide more comprehensive guidance for reviewing pull requests and implementing features in the Action Destinations repository. The update transforms the basic instruction document into a detailed guide that covers repository structure, code quality standards, and implementation best practices.

  • Expands the primary responsibilities section to clearly define Copilot's roles as both PR reviewer and implementation assistant
  • Adds comprehensive guidelines for different destination types (API/cloud, audience, browser-based) with specific considerations for each
  • Introduces detailed implementation best practices covering testing, security, performance, and feature-specific guidelines

@varadarajan-tw varadarajan-tw marked this pull request as ready for review August 21, 2025 11:15
@varadarajan-tw varadarajan-tw merged commit 73f48f1 into main Aug 21, 2025
12 checks passed
@varadarajan-tw varadarajan-tw deleted the update-copilot-instructions branch August 21, 2025 11:17
@joe-ayoub-segment
Copy link
Contributor

Hi @varadarajan-tw PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants