Skip to content

Clean up batch keys changes #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Clean up batch keys changes #3314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 18 additions & 25 deletions packages/destination-actions/src/destinations/kafka/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Kafka, ProducerRecord, Partitioners, SASLOptions, KafkaConfig, KafkaJSError, Producer } from 'kafkajs'
import { Kafka, Partitioners, SASLOptions, KafkaConfig, KafkaJSError, Producer } from 'kafkajs'
import { DynamicFieldResponse, IntegrationError, Features } from '@segment/actions-core'
import type { Settings } from './generated-types'
import type { Payload } from './send/generated-types'
Expand Down Expand Up @@ -196,36 +196,35 @@ export const sendData = async (
) => {
validate(settings)

const groupedPayloads: { [topic: string]: Payload[] } = {}
const set = new Set<string>()

payload.forEach((p) => {
const { topic, partition, default_partition } = p
if (!groupedPayloads[topic]) {
groupedPayloads[topic] = []
}
groupedPayloads[topic].push(p)
set.add(`${topic}-${partition}-${default_partition}`)
})
const topic = payload[0].topic
if (!topic) {
throw new IntegrationError('Topic is required', 'TOPIC_REQUIRED', 400)
}
if (statsContext) {
const { statsClient, tags } = statsContext
statsClient?.histogram('kafka.configurable_batch_keys.unique_keys', set.size, tags)
// Add stats to track batch keys for kafka
}

const topicMessages: TopicMessages[] = Object.keys(groupedPayloads).map((topic) => ({
const topicMessages: TopicMessages = {
topic,
messages: groupedPayloads[topic].map(
(payload) =>
messages: payload.map(
(message) =>
({
value: JSON.stringify(payload.payload),
key: payload.key,
headers: payload?.headers ?? undefined,
partition: payload?.partition ?? payload?.default_partition ?? undefined,
value: JSON.stringify(message.payload),
key: message.key,
headers: message?.headers ?? undefined,
partition: message?.partition ?? message?.default_partition ?? undefined,
partitionerType: DEFAULT_PARTITIONER
} as Message)
)
}))
}

let producer: Producer
try {
Expand All @@ -248,17 +247,11 @@ export const sendData = async (
}
}

for (const data of topicMessages) {
try {
await producer.send(data as ProducerRecord)
} catch (error) {
const kafkaError = getKafkaError(error as Error)
throw new IntegrationError(
`Kafka Producer Error - ${kafkaError.name}: ${kafkaError.message}`,
kafkaError.name,
500
)
}
try {
await producer.send(topicMessages)
} catch (error) {
const kafkaError = getKafkaError(error as Error)
throw new IntegrationError(`Kafka Producer Error - ${kafkaError.name}: ${kafkaError.message}`, kafkaError.name, 500)
}

if (features && features[FLAGON_NAME]) {
Expand Down
Loading