[TOPSORT] Add skipZeroPricePurchases setting to Topsort destination #3330
+172
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new optional setting `skipZeroPricePurchases` to filter out purchase events with items that have zero or missing unit price. - Updated the `Settings` interface and corresponding destination definition. - Implemented filtering logic in the purchase action. - Added unit tests to verify the new functionality, including scenarios for enabling and disabling the setting.
FelipeRiveraC
changed the title
joe-ayoub-segment
approved these changes
Oct 1, 2025
| const filteredItems = payload.items.filter((item) => item.unitPrice != null && item.unitPrice > 0) | ||
|
|
||
| if (filteredItems.length === 0) { | ||
| return |
There was a problem hiding this comment.
Hi @FelipeRiveraC ,
You could throw a PayloadValidationError here if you liked - it provides feedback to the customer about what happened.
It's OK not to also. Up to you.
There was a problem hiding this comment.
Hey, we actually dont want to provide feedback, so its ok. Thanks!
|
Hi @FelipeRiveraC just one minor comment. Let me know if you want this deployed or if you want to tweak it as per my comment. |
|
Ready to deploy |
|
When is this getting deployed? @joe-ayoub-segment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipZeroPricePurchasesto filter out purchase events with items that have zero or missing unit price.Settingsinterface and corresponding destination definition.A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.