Skip to content

Conversation

joe-ayoub-segment
Copy link
Contributor

@Vanessa-SSY indicated that marketing_status should be in common-fields.ts

Testing

To be tested in Production by @Vanessa-SSY
Unit tests updated.

Copy link
Contributor

github-actions bot commented Oct 1, 2025

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: StackAdapt Audiences, Action Field(s):marketing_status

Add these new fields as optional instead and assume default values in perform or performBatch block.

Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.97%. Comparing base (41a9de1) to head (a103de9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3331      +/-   ##
==========================================
- Coverage   80.32%   79.97%   -0.35%     
==========================================
  Files        1257     1204      -53     
  Lines       25159    22306    -2853     
  Branches     5217     4410     -807     
==========================================
- Hits        20208    17839    -2369     
+ Misses       4163     3685     -478     
+ Partials      788      782       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Vanessa-SSY
Copy link
Contributor

Hi @joe-ayoub-segment , I just checked with our internal team and realize that they are using a different API field for the marketing status so the following change is needed:
Screenshot 2025-10-02 at 8 14 22 PM

I have tested the above change with your PR and it's working.

@joe-ayoub-segment
Copy link
Contributor Author

Hi @Vanessa-SSY I've updated the PR as per your instructions.

@Vanessa-SSY
Copy link
Contributor

Looks good to me. Thanks!

@harsh-joshi99 harsh-joshi99 enabled auto-merge (squash) October 7, 2025 12:10
@harsh-joshi99 harsh-joshi99 disabled auto-merge October 7, 2025 12:11
@Vanessa-SSY
Copy link
Contributor

Hi @joe-ayoub-segment, we're doing end-to-end testing and not seeing the default mapping auto-populated for the standard properties(see screenshot1). The top 3 were defined manually by us. I see the fields mapped correctly in action tester (see screenshot 2) so I'm not able to re-produce the issue in dev environment. Could you help look into this issue? Is it possible to meet today's deployment if any change is needed?
Screenshot 2025-10-06 at 1 36 32 PM
Screenshot 2025-10-06 at 1 38 05 PM

@Vanessa-SSY
Copy link
Contributor

@harsh-joshi99 May I know why auto-merge is disabled? Can we still get this PR in deployment today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants