Skip to content

Conversation

@Prithviraj-rathore-segment
Copy link
Contributor

JIRA

https://twilio-engineering.atlassian.net/browse/STRATCONN-6312

A summary of your pull request, including the what change you're making and why.

Description

  1. This PR changes are done to fix the timeout issue in get category list in SFMC when user is trying to select a ‘create new data extension’ operation .
  2. This PR includes changes for applying filter in the SOAP api Request that fetch the data for category list .

Testing

Please find the testing done in staging environment .

Screenshot 2025-11-18 at 12 47 46 PM

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.02%. Comparing base (ff810c6) to head (1399d55).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
+ Coverage   79.85%   80.02%   +0.17%     
==========================================
  Files        1247     1223      -24     
  Lines       23784    22691    -1093     
  Branches     4813     4504     -309     
==========================================
- Hits        18993    18159     -834     
+ Misses       3955     3700     -255     
+ Partials      836      832       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not test changes required?

@Prithviraj-rathore-segment
Copy link
Contributor Author

LGTM! Not test changes required?

There is no test case written for this, should i write? @varadarajan-tw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants