-
Notifications
You must be signed in to change notification settings - Fork 292
Presets in default mapping Survicate #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @anna-belka please message me directly when you are ready for this PR to be reviewed. |
@joe-ayoub-segment it's ready. |
|
thanks @anna-belka looks good. I'll run CI checks now and if they pass this will go out on 3rd December. We have a deploy freeze next week. |
@joe-ayoub-segment there was an issue about dependencies, so I did updates and now CI should pass. |
joe-ayoub-segment
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anna-belka I'm sorry but we can't let you add or change any dependencies.
Can you explain why you added "ansi-regex": "^6.0.1" please?
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'