Skip to content

Conversation

@anna-belka
Copy link
Contributor

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@joe-ayoub-segment
Copy link
Contributor

Hi @anna-belka please message me directly when you are ready for this PR to be reviewed.

@anna-belka
Copy link
Contributor Author

Hi @anna-belka please message me directly when you are ready for this PR to be reviewed.

@joe-ayoub-segment it's ready.

@joe-ayoub-segment
Copy link
Contributor

thanks @anna-belka looks good. I'll run CI checks now and if they pass this will go out on 3rd December. We have a deploy freeze next week.

@anna-belka
Copy link
Contributor Author

thanks @anna-belka looks good. I'll run CI checks now and if they pass this will go out on 3rd December. We have a deploy freeze next week.

@joe-ayoub-segment there was an issue about dependencies, so I did updates and now CI should pass.

Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anna-belka I'm sorry but we can't let you add or change any dependencies.
Can you explain why you added "ansi-regex": "^6.0.1" please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants