-
Notifications
You must be signed in to change notification settings - Fork 297
STRATCONN-6410 - [Braze] - Add subscription group support to Braze user profile #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Introduces a new 'subscription_groups' field to manage user subscription status for specific groups in both updateUserProfile and updateUserProfile2 actions. Updates type definitions, action schemas, and utility functions to handle this new attribute.
packages/destination-actions/src/destinations/braze/updateUserProfile2/index.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/braze/updateUserProfile2/index.ts
Show resolved
Hide resolved
|
Hi @agouveia-twilio thanks for the PR. The change looks pretty straightforward, but there's a little more that needs to be done though before we can deploy it. We need to ensure that what gets deployed works for all customers, and not just for the customer you are working with. With that in mind please review the below:
If you need help with any of this please reach out and we can jump on a call. But see what you can get done by yourself and we can go from there. Cheers, |
|
Note: Customer asking when this will be done. |
Added the 'defaultObjectUI: keyvalue' property to the subscription groups field in both updateUserProfile and updateUserProfile2 Braze actions to improve the UI for managing subscription group objects.
Added test cases to verify handling of subscription_groups in both updateUserProfile and updateUserProfile2 Braze destination actions. Tests cover scenarios with single, multiple, batched, mixed subscription states, and absence of subscription_groups.
Extended Braze user profile update tests to cover the subscription_groups field, including cases for populated and empty arrays. Updated related snapshots to reflect the new field.
Changed the expected 'subscription_state' in the snapshot test from a placeholder value to 'unsubscribed' to reflect the correct test output.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3455 +/- ##
==========================================
- Coverage 80.06% 80.03% -0.03%
==========================================
Files 1224 1267 +43
Lines 22722 23349 +627
Branches 4505 4674 +169
==========================================
+ Hits 18192 18687 +495
- Misses 3698 3794 +96
- Partials 832 868 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Introduces a new 'subscription_groups' field to manage user subscription status for specific groups in both updateUserProfile and updateUserProfile2 actions. Updates type definitions, action schemas, and utility functions to handle this new attribute.
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'