-
Notifications
You must be signed in to change notification settings - Fork 298
tier-1/batch-5: refactor API versioning to use versioning-info module #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhandage
wants to merge
3
commits into
main
Choose a base branch
from
tier-1-batch-5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
packages/destination-actions/src/destinations/criteo-audiences/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| /** CRITEO_AUDIENCES_API_VERSION | ||
| * Criteo audience segments base API version. | ||
| * API reference: https://developers.criteo.com/marketing-solutions/v2023.10/docs/welcome-to-criteo | ||
| */ | ||
|
|
||
| export const CRITEO_AUDIENCES_API_VERSION = '2023-10' | ||
4 changes: 3 additions & 1 deletion
4
packages/destination-actions/src/destinations/klaviyo/config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/klaviyo/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** KLAVIYO_REVISION_DATE | ||
| * Klaviyo API revision date. | ||
| * API reference: https://developers.klaviyo.com/en/reference/api_overview | ||
| */ | ||
| export const KLAVIYO_REVISION_DATE = '2025-01-15' |
4 changes: 3 additions & 1 deletion
4
packages/destination-actions/src/destinations/launchdarkly-audiences/constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/launchdarkly-audiences/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** LAUNCHDARKLY_AUDIENCES_API_VERSION | ||
| * LaunchDarkly API version. | ||
| * API reference: https://launchdarkly.com/docs/api/segments | ||
| */ | ||
| export const LAUNCHDARKLY_AUDIENCES_API_VERSION = 'v2' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/moengage/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** MOENGAGE_API_VERSION | ||
| * MoEngage integrations API version. | ||
| * Private API | ||
| */ | ||
| export const MOENGAGE_API_VERSION = 'v1' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
...on-actions/src/destinations/optimizely-feature-experimentation-actions/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** OPTIMIZELY_FEATURE_EXPERIMENTATION_DELETE_API_VERSION | ||
| * Optimizely Feature Experimentation GDPR delete API version. | ||
| * API reference: https://docs.developers.optimizely.com/web-experimentation/reference/update_sar_request_by_post | ||
| */ | ||
| export const OPTIMIZELY_FEATURE_EXPERIMENTATION_DELETE_API_VERSION = 'v2' | ||
|
|
||
| /** OPTIMIZELY_FEATURE_EXPERIMENTATION_TRACK_API_VERSION | ||
| * Optimizely Feature Experimentation track events API version. | ||
| * API reference: https://docs.developers.optimizely.com/experimentation-data/reference/post_events | ||
| */ | ||
| export const OPTIMIZELY_FEATURE_EXPERIMENTATION_TRACK_API_VERSION = 'v1' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.