Skip to content

STRATCONN-6511 - [Dotdigital] - new Audience destination#3543

Open
joe-ayoub-segment wants to merge 5 commits intomainfrom
dotdigital-audiences
Open

STRATCONN-6511 - [Dotdigital] - new Audience destination#3543
joe-ayoub-segment wants to merge 5 commits intomainfrom
dotdigital-audiences

Conversation

@joe-ayoub-segment
Copy link
Contributor

Draft PR for new Dotdigital audience integration

Testing

To be done.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 76.05634% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.33%. Comparing base (38979e9) to head (025693a).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...ons/src/destinations/dotdigital-audiences/index.ts 29.41% 12 Missing ⚠️
.../destinations/dotdigital/addContactToList/index.ts 60.00% 2 Missing ⚠️
.../src/destinations/dotdigital/enrolContact/index.ts 75.00% 1 Missing ⚠️
...inations/dotdigital/removeContactFromList/index.ts 75.00% 1 Missing ⚠️
...destinations/dotdigital/sendEmailCampaign/index.ts 75.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (76.05%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3543      +/-   ##
==========================================
+ Coverage   80.11%   80.33%   +0.22%     
==========================================
  Files        1268     1285      +17     
  Lines       23399    24417    +1018     
  Branches     4687     4994     +307     
==========================================
+ Hits        18745    19615     +870     
- Misses       3784     3922     +138     
- Partials      870      880      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joe-ayoub-segment joe-ayoub-segment marked this pull request as ready for review January 27, 2026 07:16
@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner January 27, 2026 07:16
Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 comment. Could we also increase patch test coverage to greater than 80%? The codecov check is failing

},
extendRequest({ settings }) {
return {
headers: { Authorization: `Basic ${btoa(settings.username + ':' + settings.password)}`, 'x-ddg-integration-token': '7d1e8cff-4856-4f45-93d3-dac7377a53c2'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should x-ddg-integration-token be a secret? Or else I would recommend extracting this to a constant.

@pvpcookie
Copy link
Contributor

pvpcookie commented Jan 27, 2026

Hi @joe-ayoub-segment

How would you like proceed with changes ?

  • 1. We advise one changes?
  • 2. We Commit changes to your branch ?
  • 3. We branch off your branch ?

@joe-ayoub-segment
Copy link
Contributor Author

Hi @pvpcookie . You could fork from my branch, and then raise a PR straight into my branch. This way I'll see your proposed changes. If you raise a PR directly into Segment's main branch it will be harder for me to see your proposed changes as everything will be 'new'.

pvpcookie and others added 2 commits January 29, 2026 09:08
* fix incorrect apu_host const declaration

* audiance tests
@pvpcookie
Copy link
Contributor

Hi @joe-ayoub-segment

Just following up regarding this, hope all is well your side :)

@joe-ayoub-segment
Copy link
Contributor Author

joe-ayoub-segment commented Feb 3, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants