STRATCONN-6511 - [Dotdigital] - new Audience destination#3543
STRATCONN-6511 - [Dotdigital] - new Audience destination#3543joe-ayoub-segment wants to merge 5 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (76.05%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3543 +/- ##
==========================================
+ Coverage 80.11% 80.33% +0.22%
==========================================
Files 1268 1285 +17
Lines 23399 24417 +1018
Branches 4687 4994 +307
==========================================
+ Hits 18745 19615 +870
- Misses 3784 3922 +138
- Partials 870 880 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
varadarajan-tw
left a comment
There was a problem hiding this comment.
Left 1 comment. Could we also increase patch test coverage to greater than 80%? The codecov check is failing
| }, | ||
| extendRequest({ settings }) { | ||
| return { | ||
| headers: { Authorization: `Basic ${btoa(settings.username + ':' + settings.password)}`, 'x-ddg-integration-token': '7d1e8cff-4856-4f45-93d3-dac7377a53c2'}, |
There was a problem hiding this comment.
Should x-ddg-integration-token be a secret? Or else I would recommend extracting this to a constant.
|
How would you like proceed with changes ?
|
|
Hi @pvpcookie . You could fork from my branch, and then raise a PR straight into my branch. This way I'll see your proposed changes. If you raise a PR directly into Segment's main branch it will be harder for me to see your proposed changes as everything will be 'new'. |
* fix incorrect apu_host const declaration * audiance tests
|
Just following up regarding this, hope all is well your side :) |
Draft PR for new Dotdigital audience integration
Testing
To be done.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example