STRATCONN-6465 - [Appcues web] - new destination#3568
Open
joe-ayoub-segment wants to merge 6 commits intomainfrom
Open
STRATCONN-6465 - [Appcues web] - new destination#3568joe-ayoub-segment wants to merge 6 commits intomainfrom
joe-ayoub-segment wants to merge 6 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Appcues Web browser-mode destination for the Segment Actions framework. The implementation includes four core actions (track, page, identify, and group) with appropriate field mappings and a custom flatten utility function for handling nested data structures.
Changes:
- New Appcues Web browser destination with support for track, page, identify, and group events
- Custom flatten function to handle array-to-string conversions while preserving nested objects
- Comprehensive test coverage for all actions and initialization logic
- Region-based script loading (US/EU) with configurable URL detection
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/browser-destinations/destinations/appcues-web/package.json | Package configuration for the new Appcues Web destination |
| packages/browser-destinations/destinations/appcues-web/tsconfig.json | TypeScript configuration for the destination |
| packages/browser-destinations/destinations/appcues-web/README.md | Basic README with license and contribution information |
| packages/browser-destinations/destinations/appcues-web/src/index.ts | Main destination definition with settings and initialization logic |
| packages/browser-destinations/destinations/appcues-web/src/types.ts | TypeScript type definitions for Appcues SDK and settings |
| packages/browser-destinations/destinations/appcues-web/src/constants.ts | URL constants for US and EU regions |
| packages/browser-destinations/destinations/appcues-web/src/functions.ts | Utility function to flatten arrays while preserving object structure |
| packages/browser-destinations/destinations/appcues-web/src/generated-types.ts | Generated TypeScript types for destination settings |
| packages/browser-destinations/destinations/appcues-web/src/track/index.ts | Track action implementation |
| packages/browser-destinations/destinations/appcues-web/src/track/generated-types.ts | Generated types for track action payload |
| packages/browser-destinations/destinations/appcues-web/src/track/tests/index.test.ts | Tests for track action including nested property handling |
| packages/browser-destinations/destinations/appcues-web/src/page/index.ts | Page action implementation |
| packages/browser-destinations/destinations/appcues-web/src/page/generated-types.ts | Generated types for page action payload |
| packages/browser-destinations/destinations/appcues-web/src/page/tests/index.test.ts | Tests for page action |
| packages/browser-destinations/destinations/appcues-web/src/identify/index.ts | Identify action implementation with incorrect title |
| packages/browser-destinations/destinations/appcues-web/src/identify/generated-types.ts | Generated types for identify action payload |
| packages/browser-destinations/destinations/appcues-web/src/identify/tests/index.test.ts | Tests for identify action including nested traits |
| packages/browser-destinations/destinations/appcues-web/src/group/index.ts | Group action implementation |
| packages/browser-destinations/destinations/appcues-web/src/group/generated-types.ts | Generated types for group action payload |
| packages/browser-destinations/destinations/appcues-web/src/group/tests/index.test.ts | Tests for group action including nested traits |
| packages/browser-destinations/destinations/appcues-web/src/tests/initialization.test.ts | Tests for destination initialization and settings |
packages/browser-destinations/destinations/appcues-web/src/identify/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/appcues-web/src/group/index.ts
Show resolved
Hide resolved
packages/browser-destinations/destinations/appcues-web/src/group/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/appcues-web/src/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/appcues-web/src/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/appcues-web/src/index.ts
Outdated
Show resolved
Hide resolved
…ntify/index.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ex.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…up/index.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ex.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ex.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP new Appcues web integration
Testing
WIP
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example