STRATCONN-6602 - [Google Enhanced Conversions] - journeys v2 support#3648
STRATCONN-6602 - [Google Enhanced Conversions] - journeys v2 support#3648joe-ayoub-segment wants to merge 32 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3648 +/- ##
==========================================
+ Coverage 80.24% 80.81% +0.57%
==========================================
Files 1342 1378 +36
Lines 25481 27431 +1950
Branches 5268 5859 +591
==========================================
+ Hits 20447 22169 +1722
- Misses 4112 4348 +236
+ Partials 922 914 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds Journeys V2 support to the Google Enhanced Conversions Customer Match User List action by deriving add/remove operations from Engage audience membership fields in the payload (behind a feature flag).
Changes:
- Changed the User List action’s default
syncModetomirror. - Added an
engage_fieldspayload object (hidden) for extracting Engage audience membership inputs. - Implemented Engage audience membership detection in user list operation selection (feature-flagged) and added unit tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts | Updates default sync mode and introduces hidden engage_fields mappings for Engage/Journeys V2 payloads. |
| packages/destination-actions/src/destinations/google-enhanced-conversions/userList/generated-types.ts | Extends the user list payload type with engage_fields. |
| packages/destination-actions/src/destinations/google-enhanced-conversions/functions.ts | Adds feature flag + Engage membership detection and uses it to decide add/remove in mirror mode. |
| packages/destination-actions/src/destinations/google-enhanced-conversions/tests/userList.test.ts | Adds tests validating add/remove behavior based on Engage membership booleans (Journeys V2). |
.../destination-actions/src/destinations/google-enhanced-conversions/__tests__/userList.test.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/google-enhanced-conversions/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts
Outdated
Show resolved
Hide resolved
...destination-actions/src/destinations/google-enhanced-conversions/userList/generated-types.ts
Outdated
Show resolved
Hide resolved
…conversions/userList/index.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…conversions/userList/generated-types.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
Making Google Enhanced Conversions work with Journeys V2 destination, by adding fields to detect Engage audience membership from the payload.
Testing
Unit tests added.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example