Skip to content

STRATCONN-6602 - [Google Enhanced Conversions] - journeys v2 support#3648

Closed
joe-ayoub-segment wants to merge 32 commits intomainfrom
google-enhanced-conversion-journeysv2
Closed

STRATCONN-6602 - [Google Enhanced Conversions] - journeys v2 support#3648
joe-ayoub-segment wants to merge 32 commits intomainfrom
google-enhanced-conversion-journeysv2

Conversation

@joe-ayoub-segment
Copy link
Contributor

Making Google Enhanced Conversions work with Journeys V2 destination, by adding fields to detect Engage audience membership from the payload.

Testing

Unit tests added.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 90.82569% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.81%. Comparing base (1512cfc) to head (4dd29a4).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/audience-membership.ts 90.69% 4 Missing ⚠️
...ations/amplitude-cohorts/syncAudience/functions.ts 60.00% 4 Missing ⚠️
...inations/pendo-audiences/syncAudience/functions.ts 73.33% 2 Missing and 2 partials ⚠️
...tinations/google-enhanced-conversions/functions.ts 94.11% 0 Missing and 2 partials ⚠️
...ions/src/destinations/pendo-audiences/functions.ts 80.00% 2 Missing ⚠️
...-actions/src/destinations/pendo-audiences/index.ts 75.00% 2 Missing ⚠️
...tinations/the-trade-desk-crm/syncAudience/index.ts 75.00% 0 Missing and 1 partial ⚠️
...c/destinations/youappi-audiences/sync/functions.ts 98.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3648      +/-   ##
==========================================
+ Coverage   80.24%   80.81%   +0.57%     
==========================================
  Files        1342     1378      +36     
  Lines       25481    27431    +1950     
  Branches     5268     5859     +591     
==========================================
+ Hits        20447    22169    +1722     
- Misses       4112     4348     +236     
+ Partials      922      914       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Journeys V2 support to the Google Enhanced Conversions Customer Match User List action by deriving add/remove operations from Engage audience membership fields in the payload (behind a feature flag).

Changes:

  • Changed the User List action’s default syncMode to mirror.
  • Added an engage_fields payload object (hidden) for extracting Engage audience membership inputs.
  • Implemented Engage audience membership detection in user list operation selection (feature-flagged) and added unit tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts Updates default sync mode and introduces hidden engage_fields mappings for Engage/Journeys V2 payloads.
packages/destination-actions/src/destinations/google-enhanced-conversions/userList/generated-types.ts Extends the user list payload type with engage_fields.
packages/destination-actions/src/destinations/google-enhanced-conversions/functions.ts Adds feature flag + Engage membership detection and uses it to decide add/remove in mirror mode.
packages/destination-actions/src/destinations/google-enhanced-conversions/tests/userList.test.ts Adds tests validating add/remove behavior based on Engage membership booleans (Journeys V2).

…conversions/userList/index.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Amplitude Cohorts, Action Field(s):segment_external_audience_id
  • Destination: Google Ads Conversions, Action Field(s):segment_external_audience_id

Add these new fields as optional instead and assume default values in perform or performBatch block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants