Skip to content

Audience membership update - Core + multiple destinations #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joe-ayoub-segment wants to merge 27 commits into
base: main
Choose a base branch
from

removing core flag

b82ddbe
Select commit
Loading
Failed to load commit list.
Open

Audience membership update - Core + multiple destinations #3658

removing core flag
b82ddbe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 17, 2026 in 1s

80.91% (target 70.00%)

View this Pull Request on Codecov

80.91% (target 70.00%)

Details

Codecov Report

❌ Patch coverage is 76.44231% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.91%. Comparing base (83cfc2c) to head (b82ddbe).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...s/facebook-custom-audiences/sync/hook-functions.ts 17.14% 29 Missing ⚠️
...ations/facebook-custom-audiences/sync/functions.ts 83.08% 6 Missing and 17 partials ⚠️
...ons/linkedin-audiences/updateAudience/functions.ts 39.13% 13 Missing and 1 partial ⚠️
...estinations/facebook-custom-audiences/functions.ts 81.66% 7 Missing and 4 partials ⚠️
.../destinations/braze-cohorts/syncAudiences/index.ts 66.66% 6 Missing ⚠️
...ations/amplitude-cohorts/syncAudience/functions.ts 60.00% 4 Missing ⚠️
...rc/destinations/facebook-custom-audiences/index.ts 82.35% 2 Missing and 1 partial ⚠️
...stinations/facebook-custom-audiences/sync/index.ts 66.66% 3 Missing ⚠️
packages/core/src/audience-membership.ts 95.34% 2 Missing ⚠️
...tinations/google-enhanced-conversions/functions.ts 94.11% 0 Missing and 2 partials ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3658      +/-   ##
==========================================
+ Coverage   80.49%   80.91%   +0.42%     
==========================================
  Files        1320     1378      +58     
  Lines       24433    27508    +3075     
  Branches     4987     5906     +919     
==========================================
+ Hits        19667    22259    +2592     
- Misses       3859     4305     +446     
- Partials      907      944      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov