Update statusCode

Author: silesky

packages/signals/signals-example/src/lib/analytics.ts

@@ -34,7 +34,7 @@ const isStage = process.env.STAGE === 'true'
 const signalsPlugin = new SignalsPlugin({
   ...(isStage ? { apiHost: 'signals.segment.build/v1' } : {}),
   enableDebugLogging: true,
-  // processSignal: processSignalExample,
+  processSignal: processSignalExample,
 })
 
 export const loadAnalytics = () =>
@@ -46,6 +46,7 @@ export const loadAnalytics = () =>
         ...(isStage ? { cdnURL: 'https://cdn.segment.build' } : {}),
       },
       {
+        initialPageview: true,
         ...(isStage
           ? {
               integrations: {

packages/signals/signals-runtime/package.json

@@ -23,7 +23,7 @@
     "gen-editor-types": "node gen-editor-types.js",
     "build:esm": "yarn tsc -p tsconfig.build.json",
     "build:cjs": "yarn tsc -p tsconfig.build.json --outDir ./dist/cjs --module commonjs",
-    "watch": "yarn concurrently 'yarn build:bundle-dev --watch' 'yarn build:esm --watch'",
+    "watch": "yarn build:esm --watch",
     "watch:test": "yarn test --watch",
     "tsc": "yarn run -T tsc",
     "eslint": "yarn run -T eslint",

packages/signals/signals-runtime/src/mobile/mobile-signals-types.ts

@@ -1,4 +1,4 @@
-import { BaseSignal } from '../shared/shared-types'
+import { BaseSignal, ISignalsRuntime } from '../shared/shared-types'
 
 export type SignalTypes = Signal['type']
 
@@ -88,3 +88,5 @@ interface InstrumentationData {
 interface InstrumentationSignal extends RawSignal<'instrumentation'> {
   data: InstrumentationData
 }
+
+export interface MobileSignalsRuntime extends ISignalsRuntime<Signal> {}

packages/signals/signals-runtime/src/web/web-exports-globals.ts

@@ -1,9 +1,8 @@
 // all import directives will be removed in the final build
-import { ISignalsRuntime } from '../shared/shared-types'
-import { Signal } from './web-exports'
+import { WebSignalsRuntime } from './web-exports'
 
 // This will be appended to the generated code - dts-bundle-generator will not write declare const for whatever reason.
-declare const signals: ISignalsRuntime<Signal>
+declare const signals: WebSignalsRuntime
 declare const SignalType: {
   Interaction: 'interaction'
   Navigation: 'navigation'

packages/signals/signals-runtime/src/web/web-signals-types.ts

@@ -1,4 +1,5 @@
 import { BaseSignal, JSONValue } from '../shared/shared-types'
+import { ISignalsRuntime } from '../shared/shared-types'
 
 export type SignalTypes = Signal['type']
 
@@ -79,6 +80,8 @@ interface NetworkRequestData extends BaseNetworkData {
 interface NetworkResponseData extends BaseNetworkData {
   action: 'response'
   url: string
+  statusCode: number
+  ok: boolean
 }
 
 export type NetworkData = NetworkRequestData | NetworkResponseData
@@ -97,3 +100,5 @@ export type Signal =
   | InstrumentationSignal
   | NetworkSignal
   | UserDefinedSignal
+
+export interface WebSignalsRuntime extends ISignalsRuntime<Signal> {}

packages/signals/signals/src/core/buffer/index.ts

@@ -1,4 +1,4 @@
-import { Signal } from '../../types'
+import { Signal } from '@segment/analytics-signals-runtime'
 import { openDB, DBSchema, IDBPDatabase } from 'idb'
 import { logger } from '../../lib/logger'
 

packages/signals/signals/src/core/client/index.ts

@@ -1,6 +1,6 @@
 import { Analytics, segmentio } from '@segment/analytics-next'
 import { logger } from '../../lib/logger'
-import { Signal } from '../../types'
+import { Signal } from '@segment/analytics-signals-runtime'
 import { redactSignalData } from './redact'
 
 export class SignalsIngestSettings {

packages/signals/signals/src/core/client/redact.ts

@@ -1,4 +1,4 @@
-import { Signal } from '../../types'
+import { Signal } from '@segment/analytics-signals-runtime'
 
 export const redactSignalData = (signalArg: Signal): Signal => {
   const signal = structuredClone(signalArg)

packages/signals/signals/src/core/processor/processor.ts

@@ -1,5 +1,6 @@
 import { logger } from '../../lib/logger'
-import { AnyAnalytics, Signal } from '../../types'
+import { Signal } from '@segment/analytics-signals-runtime'
+import { AnyAnalytics } from '../../types'
 import { MethodName, Sandbox } from './sandbox'
 
 export class SignalEventProcessor {

packages/signals/signals/src/core/signal-generators/network-gen/helpers.ts

@@ -66,7 +66,8 @@ export function isPlainObject(obj: unknown): obj is Record<string, unknown> {
   )
 }
 
-export const isOk = (status: number) => status >= 200 && status < 300
+export const isOk = (statusCode: number) =>
+  statusCode >= 200 && statusCode < 300
 
 /**
  * Safely parse JSON, if it fails, return the original text.