change from node-fetch to undici (#680)

Author: silesky

packages/node/package.json

@@ -35,8 +35,8 @@
   "dependencies": {
     "@lukeed/uuid": "^2.0.0",
     "@segment/analytics-core": "1.1.2",
-    "node-fetch": "^2.6.7",
-    "tslib": "^2.4.0"
+    "tslib": "^2.4.0",
+    "undici": "^5.12.0"
   },
   "devDependencies": {
     "@internal/config": "0.0.0",

packages/node/src/__tests__/graceful-shutdown-integration.test.ts

@@ -1,7 +1,7 @@
 import { createSuccess } from './test-helpers/factories'
 
 const fetcher = jest.fn()
-jest.mock('../lib/fetch', () => fetcher)
+jest.mock('../lib/fetch', () => ({ fetch: fetcher }))
 
 import { Analytics, SegmentEvent } from '../app/analytics-node'
 import { sleep } from './test-helpers/sleep'

packages/node/src/__tests__/http-integration.test.ts

@@ -1,5 +1,5 @@
 const fetcher = jest.fn()
-jest.mock('../lib/fetch', () => fetcher)
+jest.mock('../lib/fetch', () => ({ fetch: fetcher }))
 
 import { createSuccess } from './test-helpers/factories'
 import { version } from '../../package.json'

packages/node/src/__tests__/integration.test.ts

@@ -1,5 +1,5 @@
 const fetcher = jest.fn()
-jest.mock('../lib/fetch', () => fetcher)
+jest.mock('../lib/fetch', () => ({ fetch: fetcher }))
 
 import { CorePlugin as Plugin } from '@segment/analytics-core'
 import { resolveCtx } from './test-helpers/resolve-ctx'

packages/node/src/lib/fetch.ts

@@ -1,6 +1,3 @@
-import { default as nodeFetch } from 'node-fetch'
+import { fetch as _fetch } from 'undici'
 
-// made this a default export so it mocks the same as node-fetch in tests.
-const fetch = globalThis.fetch || nodeFetch
-
-export default fetch
+export const fetch = globalThis.fetch || _fetch

packages/node/src/plugins/segmentio/__tests__/index.test.ts

@@ -1,5 +1,5 @@
 const fetcher = jest.fn()
-jest.mock('../../../lib/fetch', () => fetcher)
+jest.mock('../../../lib/fetch', () => ({ fetch: fetcher }))
 
 import { CoreContext } from '@segment/analytics-core'
 import { createNodeEventFactory } from '../../../lib/create-node-event-factory'

packages/node/src/plugins/segmentio/publisher.ts

@@ -1,7 +1,7 @@
 import { backoff, CoreContext } from '@segment/analytics-core'
 import { tryCreateFormattedUrl } from '../../lib/create-url'
 import { extractPromiseParts } from '../../lib/extract-promise-parts'
-import fetch from '../../lib/fetch'
+import { fetch } from '../../lib/fetch'
 import { ContextBatch } from './context-batch'
 
 function sleep(timeoutInMs: number): Promise<void> {

yarn.lock

@@ -1897,8 +1897,8 @@ __metadata:
     "@lukeed/uuid": ^2.0.0
     "@segment/analytics-core": 1.1.2
     "@types/node": ^14
-    node-fetch: ^2.6.7
     tslib: ^2.4.0
+    undici: ^5.12.0
   languageName: unknown
   linkType: soft
 
@@ -5118,6 +5118,15 @@ __metadata:
   languageName: node
   linkType: hard
 
+"busboy@npm:^1.6.0":
+  version: 1.6.0
+  resolution: "busboy@npm:1.6.0"
+  dependencies:
+    streamsearch: ^1.1.0
+  checksum: 32801e2c0164e12106bf236291a00795c3c4e4b709ae02132883fe8478ba2ae23743b11c5735a0aae8afe65ac4b6ca4568b91f0d9fed1fdbc32ede824a73746e
+  languageName: node
+  linkType: hard
+
 "bytes-iec@npm:^3.1.1":
   version: 3.1.1
   resolution: "bytes-iec@npm:3.1.1"
@@ -12691,6 +12700,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"streamsearch@npm:^1.1.0":
+  version: 1.1.0
+  resolution: "streamsearch@npm:1.1.0"
+  checksum: 1cce16cea8405d7a233d32ca5e00a00169cc0e19fbc02aa839959985f267335d435c07f96e5e0edd0eadc6d39c98d5435fb5bbbdefc62c41834eadc5622ad942
+  languageName: node
+  linkType: hard
+
 "string-argv@npm:^0.3.1":
   version: 0.3.1
   resolution: "string-argv@npm:0.3.1"
@@ -13667,6 +13683,15 @@ __metadata:
   languageName: node
   linkType: hard
 
+"undici@npm:^5.12.0":
+  version: 5.12.0
+  resolution: "undici@npm:5.12.0"
+  dependencies:
+    busboy: ^1.6.0
+  checksum: fbc227704943c05aa3dc1630695e10309c17d0a535678594d136db107c50593248e9ace70e1ab77496a6c837bf14aa2ab3c501a7a6c45fb6277dbf0846e15ffe
+  languageName: node
+  linkType: hard
+
 "unfetch@npm:^3.1.1":
   version: 3.1.2
   resolution: "unfetch@npm:3.1.2"