Add initial signals

Author: silesky

packages/signals/signals/src/types/factories.ts

@@ -1,81 +1,39 @@
 import {
-  InstrumentationSignal,
-  InteractionData,
-  InteractionSignal,
   NavigationData,
   NavigationSignal,
   UserDefinedSignalData,
   UserDefinedSignal,
   NetworkData,
   NetworkSignalMetadata,
   NetworkSignal,
-  SegmentEvent,
+  SignalTypes,
+  Signal,
+  SignalOfType,
 } from '@segment/analytics-signals-runtime'
 import { normalizeUrl } from '../lib/normalize-url'
 import { getPageData } from '../lib/page-data'
 
-/**
- * Factories
- */
-export const createInstrumentationSignal = (
-  rawEvent: SegmentEvent
-): InstrumentationSignal => {
-  return {
-    type: 'instrumentation',
-    data: {
-      page: getPageData(),
-      rawEvent,
-    },
-  }
-}
-
-export const createInteractionSignal = (
-  data: InteractionData
-): InteractionSignal => {
-  return {
-    type: 'interaction',
-    data: {
-      ...data,
-      page: getPageData(),
-    },
-  }
-}
-
 export const createNavigationSignal = (
   data: NavigationData
 ): NavigationSignal => {
-  return {
-    type: 'navigation',
-    data: {
-      ...data,
-      page: getPageData(),
-    },
-  }
+  return createInitialSignal('navigation', data)
 }
 
 export const createUserDefinedSignal = (
   data: UserDefinedSignalData
 ): UserDefinedSignal => {
-  return {
-    type: 'userDefined',
-    data: {
-      ...data,
-      page: getPageData(),
-    },
-  }
+  return createInitialSignal('userDefined', data)
 }
 
 export const createNetworkSignal = (
   data: NetworkData,
   metadata?: NetworkSignalMetadata
 ): NetworkSignal => {
   return {
-    type: 'network',
-    data: {
+    ...createInitialSignal('network', {
       ...data,
       url: normalizeUrl(data.url),
-      page: getPageData(),
-    },
+    }),
     metadata: metadata ?? {
       filters: {
         allowed: [],
@@ -84,3 +42,21 @@ export const createNetworkSignal = (
     },
   }
 }
+
+const createInitialSignal = <
+  Type extends SignalTypes,
+  Data extends Omit<SignalOfType<Signal, Type>['data'], 'page'>
+>(
+  type: Type,
+  data: Data
+) => {
+  return {
+    timestamp: new Date().toISOString(),
+    anonymousId: '', // not set yet -- will be set by the runtime // TODO
+    type,
+    data: {
+      ...data,
+      page: getPageData(),
+    },
+  } as SignalOfType<Signal, Type>
+}