Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Jan 13, 2025

  • consolidate settings into a single file
  • change some confusingly named variable names

@silesky silesky requested a review from danieljackins January 13, 2025 22:09
@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: a0167f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@segment/analytics-core Patch
@segment/analytics-next Patch
@segment/analytics-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky requested a review from bsneed January 13, 2025 22:11
@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.92%. Comparing base (22e6b16) to head (a0167f0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/core/src/events/index.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
- Coverage   82.93%   82.92%   -0.01%     
==========================================
  Files         216      216              
  Lines        5788     5785       -3     
  Branches     1308     1308              
==========================================
- Hits         4800     4797       -3     
  Misses        988      988              
Flag Coverage Δ
browser 92.23% <100.00%> (-0.01%) ⬇️
core 89.86% <87.50%> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silesky silesky merged commit 7f9d5a0 into master Jan 13, 2025
8 checks passed
@silesky silesky deleted the settings-refactor branch January 13, 2025 22:36
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants