Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Feb 14, 2025

Add workaround for bug in react-hook-form, where the field registration name "name" conflicts with the actual field property name, and causes the event.name in the HTMLInputElement to be overridden from string -> unserializable react object.

Addresses #1228

image

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: a7676a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 79.66102% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.78%. Comparing base (82bc27b) to head (a7676a6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...c/core/signal-generators/dom-gen/element-parser.ts 84.61% 8 Missing ⚠️
...es/signals/signals/src/core/processor/processor.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
+ Coverage   83.68%   83.78%   +0.09%     
==========================================
  Files         219      220       +1     
  Lines        5843     5857      +14     
  Branches     1330     1335       +5     
==========================================
+ Hits         4890     4907      +17     
+ Misses        953      950       -3     
Flag Coverage Δ
browser 92.22% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silesky silesky changed the title fix circular submit on signals Fix circular submit on signals Feb 14, 2025
@silesky silesky changed the title Fix circular submit on signals Fix react-hook-form circular submit on signals Feb 14, 2025
@silesky silesky merged commit 91dab92 into master Feb 18, 2025
8 checks passed
@silesky silesky deleted the fix-circular-submit-on-signals branch February 18, 2025 17:31
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants