-
Notifications
You must be signed in to change notification settings - Fork 155
Fix react-hook-form circular submit on signals #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a7676a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
+ Coverage 83.68% 83.78% +0.09%
==========================================
Files 219 220 +1
Lines 5843 5857 +14
Branches 1330 1335 +5
==========================================
+ Hits 4890 4907 +17
+ Misses 953 950 -3
☔ View full report in Codecov by Sentry. |
Add workaround for bug in react-hook-form, where the field registration name "name" conflicts with the actual field property name, and causes the event.name in the HTMLInputElement to be overridden from string -> unserializable react object.
Addresses #1228