Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Feb 15, 2025

MAX_BUFFER_SIZE wasn't being set properly.

@codecov
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.68%. Comparing base (82bc27b) to head (fff66c9).

Files with missing lines Patch % Lines
packages/signals/signals/src/core/buffer/index.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1233   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files         219      219           
  Lines        5843     5843           
  Branches     1330     1332    +2     
=======================================
  Hits         4890     4890           
  Misses        953      953           
Flag Coverage Δ
browser 92.22% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silesky silesky merged commit 9b47033 into master Feb 18, 2025
8 checks passed
@silesky silesky deleted the signal-buffer-max branch February 18, 2025 17:08
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants