Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Mar 7, 2025

Fix argument resolver bug where the following would not set the correct options:

analytics.page(
   null, 
   'foo', 
   { url: "https://foo.com" }, 
   { context: { __eventOrigin: { type: 'Signal' } } // would not result in the correct context object.
)

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: 8d224ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@segment/analytics-next Minor
@segment/analytics-signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (7c24459) to head (8d224ab).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
+ Coverage   77.06%   83.85%   +6.78%     
==========================================
  Files         139      221      +82     
  Lines        3249     5872    +2623     
  Branches      690     1344     +654     
==========================================
+ Hits         2504     4924    +2420     
- Misses        745      948     +203     
Flag Coverage Δ
browser 92.26% <100.00%> (?)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@silesky silesky requested a review from alanjcharles March 7, 2025 21:22
@silesky silesky changed the title Fix argument resolver bug Fix argument resolver interpreting settings arg correctly if first arg is null Mar 7, 2025
@silesky silesky changed the title Fix argument resolver interpreting settings arg correctly if first arg is null Fix argument resolver interpreting settings arg correctly if first and/or second arg is null Mar 7, 2025
@silesky silesky requested a review from didiergarcia March 10, 2025 17:09
@silesky silesky merged commit ee838db into master Mar 11, 2025
8 checks passed
@silesky silesky deleted the fix-event-context-bug-signals branch March 11, 2025 17:31
@github-actions github-actions bot mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants