Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Mar 12, 2025

When we release 1.78.0 analytics.js, we want 1.78.0 to be a valid peer dependency for Signals.

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2025

⚠️ No Changeset found

Latest commit: 628943b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@silesky silesky requested a review from didiergarcia March 12, 2025 17:24
@silesky silesky changed the title Update signals peer deps Fix signals peer deps for 1.78.0 Mar 12, 2025
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (1402a33) to head (628943b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files         221      221           
  Lines        5872     5872           
  Branches     1344     1344           
=======================================
  Hits         4924     4924           
  Misses        948      948           
Flag Coverage Δ
browser 92.26% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@silesky silesky merged commit cc14e52 into master Mar 12, 2025
7 of 8 checks passed
@silesky silesky deleted the tweak-signals-peerDeps branch March 12, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants