Check attempts before dispatching to segment #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d458034 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
+ Coverage 84.02% 84.04% +0.02%
==========================================
Files 224 224
Lines 5921 5924 +3
Branches 1351 1352 +1
==========================================
+ Hits 4975 4979 +4
+ Misses 946 945 -1
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
silesky
previously approved these changes
Apr 15, 2025
silesky
reviewed
Apr 15, 2025
| let analytics: Analytics | ||
| let segment: Plugin | ||
| beforeEach(async () => { | ||
| jest.useRealTimers() |
Contributor
There was a problem hiding this comment.
I generally just just make this at afterEach -- and beforeEach can just have 'jest.useFakeTimers()`
silesky
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the retry behavior for Segment.io by checking the number of attempts before it attempts to send the event to Segment, which was causing an extra retry.
Tested locally by verifying that a cancelled event was not retried when retryQueue was disabled, and 4 total attempts were made when retryQueue was enabled.
yarn changeset. Read about changesets here).