Skip to content

Update Node.js version to ^20 across the repository #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

Update Node.js version to ^20 across the repository #1307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
197cc44
Update Node.js version to ^20 across the repository
neelkanth-kaushik Jun 9, 2025
3dab3d6
Changed node version from ^20 to >=20
neelkanth-kaushik Jun 9, 2025
959310d
Added Changesheet
neelkanth-kaushik Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18]
node-version: [20]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18]
node-version: [20]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
2 changes: 1 addition & 1 deletion packages/node/package.json
View file
Open in desktop
Copy link
Contributor

@silesky silesky Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset for this change? Minor bump is fine.

Copy link
Contributor Author

@neelkanth-kaushik neelkanth-kaushik Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"!*.tsbuildinfo"
],
"engines": {
"node": ">=18"
"node": "^20"
Copy link
Contributor

@silesky silesky Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want ">=", since this affects all consumers of this library (not just us!)

Copy link
Contributor Author

@neelkanth-kaushik neelkanth-kaushik Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then in the root package.json as well it should be ">=20" rather than "^20"

Copy link
Contributor Author

@neelkanth-kaushik neelkanth-kaushik Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done it in both node/package.json and root package.json

},
"scripts": {
".": "yarn run -T turbo run --filter=@segment/analytics-node",
Expand Down