Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Aug 28, 2025

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2025

⚠️ No Changeset found

Latest commit: 6d6944f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@silesky silesky requested a review from Copilot August 28, 2025 18:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the old signals folder by deleting the README.md file containing documentation for the @segment/analytics-signals package. The deletion removes comprehensive documentation including installation instructions, usage examples, configuration options, and API references.

  • Removes the entire README.md file from the signals package
  • Eliminates documentation for installation, configuration, and usage patterns
  • Removes examples for both snippet and npm users

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.19%. Comparing base (84cb360) to head (6d6944f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1322   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         163      163           
  Lines        4383     4383           
  Branches     1052     1052           
=======================================
  Hits         3997     3997           
  Misses        386      386           
Flag Coverage Δ
browser 92.21% <ø> (ø)
core 89.86% <ø> (ø)
node 87.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@silesky silesky requested a review from chenxzhang August 28, 2025 18:37
@silesky silesky changed the title Delete signals folder Delete signals docs folder Aug 28, 2025
@silesky silesky changed the title Delete signals docs folder Delete github signals docs folder Aug 28, 2025
@silesky silesky changed the title Delete github signals docs folder Remove github signals docs folder Aug 28, 2025
@silesky silesky enabled auto-merge (squash) August 28, 2025 18:39
@silesky silesky merged commit 235ddf9 into master Aug 28, 2025
7 checks passed
@silesky silesky deleted the delete-signals-folder branch August 28, 2025 19:31
aalkhodiry added a commit to nayla-finance/analytics-next that referenced this pull request Nov 2, 2025
* Small repo chores (segmentio#1289)

* Migrate consent integration tests to Playwright (segmentio#1292)

Co-authored-by: Neelkanth Kaushik <[email protected]>

* Fix jira automation (segmentio#1301)

* Update Node.js version to ^20 across the repository (segmentio#1307)

* Expose BaseUserTraits (segmentio#1306)

* change to minor release (segmentio#1310)

* Version Packages (segmentio#1309)

* Update to use new signals specification (segmentio#1311)

* Move signals packages out of repo (segmentio#1315)

* Add architecture documentation (segmentio#1319)

* Update dependencies for snyk issues (segmentio#1321)

* Remove github signals docs folder (segmentio#1322)

* Fix filtering of non-consented device mode integrations (segmentio#1328)

* Version Packages (segmentio#1329)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update RELEASING.md on how to rotate npm tokens (segmentio#1330)

---------

Co-authored-by: Seth Silesky <[email protected]>
Co-authored-by: Neelkanth Kaushik <[email protected]>
Co-authored-by: Chenxiang Zhang <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants