-
Notifications
You must be signed in to change notification settings - Fork 155
Remove github signals docs folder #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the old signals folder by deleting the README.md file containing documentation for the @segment/analytics-signals package. The deletion removes comprehensive documentation including installation instructions, usage examples, configuration options, and API references.
- Removes the entire README.md file from the signals package
- Eliminates documentation for installation, configuration, and usage patterns
- Removes examples for both snippet and npm users
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1322 +/- ##
=======================================
Coverage 91.19% 91.19%
=======================================
Files 163 163
Lines 4383 4383
Branches 1052 1052
=======================================
Hits 3997 3997
Misses 386 386
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Small repo chores (segmentio#1289) * Migrate consent integration tests to Playwright (segmentio#1292) Co-authored-by: Neelkanth Kaushik <[email protected]> * Fix jira automation (segmentio#1301) * Update Node.js version to ^20 across the repository (segmentio#1307) * Expose BaseUserTraits (segmentio#1306) * change to minor release (segmentio#1310) * Version Packages (segmentio#1309) * Update to use new signals specification (segmentio#1311) * Move signals packages out of repo (segmentio#1315) * Add architecture documentation (segmentio#1319) * Update dependencies for snyk issues (segmentio#1321) * Remove github signals docs folder (segmentio#1322) * Fix filtering of non-consented device mode integrations (segmentio#1328) * Version Packages (segmentio#1329) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update RELEASING.md on how to rotate npm tokens (segmentio#1330) --------- Co-authored-by: Seth Silesky <[email protected]> Co-authored-by: Neelkanth Kaushik <[email protected]> Co-authored-by: Chenxiang Zhang <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Superceded by https://github.com/segment-integrations/signals-javascript (private)