Skip to content

Proxy datatype was wrong in test #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Proxy datatype was wrong in test #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion segment/analytics/test/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,6 @@ def test_default_timeout_15(self):
self.assertEqual(consumer.timeout, 15)

def test_proxies(self):
client = Client('testsecret', proxies='203.243.63.16:80')
client = Client('testsecret', proxies={'http':'203.243.63.16:80','https':'203.243.63.16:80'})
success, msg = client.identify('userId', {'trait': 'value'})
self.assertTrue(success)
2 changes: 1 addition & 1 deletion segment/analytics/test/test_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def mock_post_fn(_, data, **kwargs):

@classmethod
def test_proxies(cls):
consumer = Consumer(None, 'testsecret', proxies='203.243.63.16:80')
consumer = Consumer(None, 'testsecret', proxies={'http':'203.243.63.16:80','https':'203.243.63.16:80'})
track = {
'type': 'track',
'event': 'python event',
Expand Down
2 changes: 1 addition & 1 deletion segment/analytics/test/test_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ def test_proxies(self):
'userId': 'userId',
'event': 'python event',
'type': 'track',
'proxies': '203.243.63.16:80'
'proxies': {'http':'203.243.63.16:80','https':'203.243.63.16:80'}
}])
self.assertEqual(res.status_code, 200)