Skip to content

Fixes for Github Issue #516, #515 and #493 #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+30 −8
Open

Fixes for Github Issue #516, #515 and #493 #517

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9adcdf3
Fixed Github Issue #516
neelkanth-kaushik Nov 10, 2025
bc05a1f
Updated release version
neelkanth-kaushik Nov 10, 2025
8b25b71
Fixed Github Issue 515
neelkanth-kaushik Nov 12, 2025
aaf34b0
Updated HISTORY.md
neelkanth-kaushik Nov 18, 2025
11e1edb
Minor changes and conditional fix
neelkanth-kaushik Nov 18, 2025
16d829b
Merge pull request #519 from segmentio/neelkanth-kaushik/LIBRARIES-2730
neelkanth-kaushik Nov 18, 2025
d36e502
Updated HISTORY.md
neelkanth-kaushik Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 2.3.5 / 2025-11-10
- Fixed Github Issue #516

# 2.3.4 / 2025-2-24
- Fix for proxy values not being used

Expand Down
4 changes: 3 additions & 1 deletion segment/analytics/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@
# lower to leave space for extra data that will be added later, eg. "sentAt".
BATCH_SIZE_LIMIT = 475000


class FatalError(Exception):
def __init__(self, message):
self.message = message

def __str__(self):
msg = "[Segment] {0})"
return msg.format(self.message)
Expand Down Expand Up @@ -81,7 +83,7 @@ def upload(self):
# mark items as acknowledged from queue
for _ in batch:
self.queue.task_done()
return success
return success

def next(self):
"""Return the next batch of items to upload."""
Expand Down
2 changes: 1 addition & 1 deletion segment/analytics/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
VERSION = '2.3.4'
VERSION = '2.3.5'