Skip to content

simplified app name determination #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

simplified app name determination #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions Sources/Segment/Plugins/Context.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,23 +61,16 @@ public class Context: PlatformPlugin {
"version": __segment_version,
]

// app info
let info = Bundle.main.infoDictionary
let localizedInfo = Bundle.main.localizedInfoDictionary
var app = [String: Any]()
if let info = info {
app.merge(info) { (_, new) in new }
}
if let localizedInfo = localizedInfo {
app.merge(localizedInfo) { (_, new) in new }
}
if app.count != 0 {
var name: String = ""
if let displayName = app["CFBundleDisplayName"] as? String {
name = displayName
} else if let displayName = app["CFBundleName"] as? String {
name = displayName
}
// app information
let info = Bundle.main.infoDictionary ?? [:]
let localizedInfo = Bundle.main.localizedInfoDictionary ?? [:]
let app = info.merging(localizedInfo) { _, localized in localized }

if !app.isEmpty {
let name = app["CFBundleDisplayName"] as? String
?? app["CFBundleName"] as? String
?? ""

staticContext["app"] = [
"name": name,
"version": app["CFBundleShortVersionString"] ?? "",
Expand All @@ -87,7 +80,6 @@ public class Context: PlatformPlugin {
}

insertStaticPlatformContextData(context: &staticContext)

return staticContext
}

Expand Down
Loading