-
Notifications
You must be signed in to change notification settings - Fork 138
(non-prod) STRATCONN-6104: fix the pipeline to run all tests on master and remove publish step #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request refactors the Buildkite CI pipeline to separate test execution workflows for the master branch from other branches, ensuring that all tests run on master without the --since master flag that limits testing to changed packages only. The publish step is also removed from the pipeline.
Key changes:
- New test scripts (
test-master,test-master:ci) that run all tests without the--since masterflag - Separate Buildkite pipeline steps for
masterbranch (build_master,sauce_labs_master) that use the new test scripts - Existing pipeline steps updated to exclude
masterbranch usingbranches: "!master"
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| package.json | Adds packageManager field for Yarn version pinning and introduces new test scripts for running all tests on master branch |
| .gitignore | Adds .idea/ directory to ignored files for IDE configuration exclusion |
| .buildkite/pipeline.yml | Creates separate CI steps for master branch, updates branch filters on existing steps, modifies wait dependencies, and removes publish step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates the Buildkite pipeline configuration to better separate CI workflows for the
masterbranch from other branches, and introduces new scripts inpackage.jsonto support this separation. The changes improve clarity and reliability of CI runs, especially for themasterbranch, and remove the publish step from the pipeline.Pipeline configuration updates:
masterbranch:build_masterandsauce_labs_master, each with their own commands and environment settings. These steps ensure thatmasterruns use dedicated test scripts and Docker images. [1] [2]buildandsauce_labs) to exclude themasterbranch, so they only run on non-master branches. [1] [2]master-specific steps, ensuring correct build sequencing.:cloud: Publishstep from the pipeline, so publishing no longer occurs automatically onmaster.Script and package management updates:
package.json(test-master,test-master:ci) for running tests onmasterwithout the--since masterflag, and specified the Yarn version in thepackageManagerfield.