Skip to content

correct lengthRemain handling into message_read.readMessageV2 #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

correct lengthRemain handling into message_read.readMessageV2 #1411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions message_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,9 @@ func (r *messageSetReader) readMessageV2(_ int64, key readBytesFunc, val readByt
// stack. here we set the parent count to 0 so that when the child set is exhausted, the
// reader will then try to read the header of the next message set
r.readerStack.parent.count = 0
// lengthRemain have to be adjusted to length of decompressed data
// otherwise we can end up with negative lengthRemain that will fail the check into batch.go:readMessage:283, that leads to endlessly reading the same compacted batch
r.lengthRemain = r.remain
}
}
remainBefore := r.remain
Expand Down