Skip to content

Commit c4615d4

Browse files
authored
Apply suggestions from code review
1 parent 74767f5 commit c4615d4

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

src/connections/destinations/catalog/amazon-kinesis-firehose/index.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,9 @@ To attach multiple sources to your IAM role:
180180
}
181181
```
182182

183-
#### Use secret ID
183+
#### Use Secret ID
184184

185-
If you have many sources using Kinesis that it's impractical to attach all of their IDs to your IAM role, you can instead opt to set a secret ID.
185+
If you have many sources using Kinesis that it's impractical to attach all of their IDs to your IAM role, you can instead opt to set a Secret ID.
186186

187187
To set this value for a Secret ID:
188188
1. Go to the Kinesis Firehose destination settings from each of your Segment sources.
@@ -211,9 +211,8 @@ To set this value for a Secret ID:
211211
]
212212
}
213213
```
214-
6. Replace the value of `sts:ExternalId` ( "YOUR_SEGMENT_SOURCE_ID") with the Secret ID value from the previous step. In the exceptional case of requiring the use multiple secretIds replace the `sts:ExternalId` setting above with:
214+
6. Replace the value of `sts:ExternalId` ( "YOUR_SEGMENT_SOURCE_ID") with the Secret ID value from the previous step. In the case of requiring the use of multiple secretIds, replace the `sts:ExternalId` setting above with:
215215

216216
```
217217
"sts:ExternalId": ["A_SECRET_ID", "ANOTHER_SECRET_ID"]
218218
```
219-

src/connections/destinations/catalog/amazon-kinesis/index.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ After you update the IAM policy, Segment systems default to use PutRecords for m
217217
If you have many sources using Kinesis that it's impractical to attach all of their IDs to your IAM role, you can instead opt to set a secret ID. To set this value:
218218
1. Go to **Connections > Destinations > Amazon Kinesis** for each of your Segment sources.
219219
2. Click **Secret ID** and enter your Workspace ID.
220-
* **NOTE:** For security purposes, Segment recommends you to use your Workspace ID as your Secret ID. If you’re using a Secret ID different from your Workspace ID, consider changing it. You can find your Workspace ID by going to: **Settings > Workspace Settings > ID**.
220+
* **NOTE:** For security purposes, Segment recommends you to use your Workspace ID as your Secret ID. If you’re using a Secret ID different from your Workspace ID, please change it to make your account more secure. You can find your Workspace ID by going to: **Settings > Workspace Settings > ID**.
221221
3. Once all of your sources have been updated to use this value, find the IAM role you created for this destination in the AWS Console in **Services > IAM > Roles**.
222222
4. Click on the role and navigate to the **Trust Relationships** tab.
223223
5. Click **Edit trust relationship**. You should see a snippet that looks something that looks like this:
@@ -241,8 +241,8 @@ If you have many sources using Kinesis that it's impractical to attach all of th
241241
]
242242
}
243243
```
244-
6. Replace the value of `sts:ExternalId` (`"YOUR_SEGMENT_SOURCE_ID"`) with your Secret ID. In the exceptional case of requiring the use multiple secretIds replace the `sts:ExternalId` setting above with:
244+
6. Replace the value of `sts:ExternalId` (`"YOUR_SEGMENT_SOURCE_ID"`) with your Secret ID. In the case of requiring the use of multiple secretIds, replace the `sts:ExternalId` setting above with:
245245

246246
```
247247
"sts:ExternalId": ["A_SECRET_ID", "ANOTHER_SECRET_ID"]
248-
```
248+
```

src/connections/destinations/catalog/amazon-lambda/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ To create an IAM role:
145145

146146
![](images/LambdaTrustRelationship.png)
147147

148-
7. Copy and paste the following code into your trust relationship. You should replace `<your-source-id>` with either the Source ID of the attached Segment source (the default) or the value of external ID set in your AWS Lambda destination settings.
148+
7. Copy and paste the following code into your trust relationship. You should replace `<your-source-id>` with either the Source ID of the attached Segment source (the default) or the External ID set in your AWS Lambda destination settings.
149149
* `arn:aws:iam::595280932656:root` refers to Segment's AWS Account, and is what allows Segment's Destination to access the role to invoke your Lambda.
150150

151151
> note ""
@@ -171,7 +171,7 @@ To create an IAM role:
171171
}
172172
```
173173

174-
If you have multiple Sources using this Role, or require the use multiple externalIds replace the `sts:ExternalId` setting above with:
174+
If you have multiple Sources using this Role, or require the use of multiple External Ids, replace the `sts:ExternalId` setting above with:
175175

176176
```
177177
"sts:ExternalId": ["YOUR_SEGMENT_SOURCE_ID", "ANOTHER_SOURCE_ID", "AN_EXTERNAL_ID", "ANOTHER_EXTERNAL_ID"]

src/connections/destinations/catalog/amazon-personalize/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ To create an IAM role:
716716
}
717717
```
718718

719-
If you have multiple Sources using this Role, or require the use multiple externalIds replace the `sts:ExternalId` setting above with:
719+
If you have multiple Sources using this Role, or require the use of multiple externalIds, replace the `sts:ExternalId` setting above with:
720720

721721
```
722722
"sts:ExternalId": ["YOUR_SEGMENT_SOURCE_ID", "ANOTHER_SOURCE_ID", "AN_EXTERNAL_ID", "ANOTHER_EXTERNAL_ID"]

0 commit comments

Comments
 (0)