Skip to content

Conversation

forstisabella
Copy link
Contributor

Proposed changes

  • Hid the destMethods line
  • Hid fields, as requested by PM

Merge timing

ASAP!

Related issues (optional)

#6913

@forstisabella forstisabella added the back-end fixes or updates to the site itself, which should not go in release notes label Aug 9, 2024
@forstisabella forstisabella requested a review from a team as a code owner August 9, 2024 21:38
@forstisabella forstisabella requested a review from pwseg August 9, 2024 21:38
Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit b19afd8
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/66b68c9d3903ee00081fb7e9
😎 Deploy Preview https://deploy-preview-6927--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@forstisabella forstisabella changed the base branch from master to develop August 9, 2024 22:05
pwseg
pwseg previously approved these changes Aug 10, 2024
@forstisabella forstisabella dismissed pwseg’s stale review August 10, 2024 00:49

The merge-base changed after approval.

@forstisabella forstisabella requested a review from pwseg August 12, 2024 14:14
pwseg
pwseg previously approved these changes Aug 12, 2024
@forstisabella forstisabella dismissed pwseg’s stale review August 12, 2024 15:47

The merge-base changed after approval.

pwseg
pwseg previously approved these changes Aug 12, 2024
@forstisabella forstisabella dismissed pwseg’s stale review August 12, 2024 16:01

The merge-base changed after approval.

pwseg
pwseg previously approved these changes Aug 12, 2024
@forstisabella forstisabella dismissed pwseg’s stale review August 12, 2024 16:09

The merge-base changed after approval.

@forstisabella forstisabella disabled auto-merge August 12, 2024 16:12
@forstisabella forstisabella reopened this Aug 12, 2024
@forstisabella forstisabella requested a review from pwseg August 12, 2024 16:12
@forstisabella forstisabella merged commit a69880d into develop Aug 12, 2024
5 checks passed
@forstisabella forstisabella deleted the hidden-fields-troubleshooting-fcaa branch August 12, 2024 16:15
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end fixes or updates to the site itself, which should not go in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants