Skip to content

[TOPSORT] added topsort events destination docs #6952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 28, 2024
Merged

[TOPSORT] added topsort events destination docs #6952

merged 23 commits into from
Aug 28, 2024

Conversation

agustinespildora
Copy link
Contributor

Note

READY FOR REVIEW

Proposed changes

This is the docs entry for the new Topsort Destination. Any comment, syntax or anything I missed please let me know.

Merge timing

Not urgent at the moment. The sooner the better though.

@agustinespildora agustinespildora requested a review from a team as a code owner August 19, 2024 14:23
@agustinespildora agustinespildora changed the title feat: added topsort events destination docs [TOPSORT] added topsort events destination docs Aug 19, 2024
@forstisabella forstisabella added the new-integration Added a new source or destination label Aug 19, 2024
forstisabella
forstisabella reviewed Aug 19, 2024
View reviewed changes
agustinespildora and others added 10 commits August 20, 2024 13:09
@agustinespildora @forstisabella
Remove comment
8167d46 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
Syntax and spelling
815e9b5 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
Added description afterwards
c9f4bf4 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
delete comment
058de97 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
Syntax and spelling
639fb6c 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
Syntax and spelling
5c98cb9 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
Syntax and spelling
a48c2f8 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
Syntax and spelling
2aa03d9 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
Syntax and spelling
99be1b6 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
Syntax and spelling
47086c8 
Co-authored-by: forstisabella <[email protected]>
tcgilbert
tcgilbert suggested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes and questions. Please address all of @forstisabella' s suggestions as well

forstisabella
forstisabella reviewed Aug 21, 2024
View reviewed changes
forstisabella
forstisabella reviewed Aug 21, 2024
View reviewed changes
forstisabella
forstisabella reviewed Aug 21, 2024
View reviewed changes
forstisabella
forstisabella reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small comments and we'll be ready to ship this!

agustinespildora and others added 2 commits August 21, 2024 18:59
@agustinespildora @forstisabella
spelling and redaction fix
f84a529 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
spelling and redaction fix
d603aef 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora @forstisabella
spelling and redaction fix
00b7134 
Co-authored-by: forstisabella <[email protected]>
@agustinespildora
Copy link
Contributor Author

Ready! Thanks so much for the reviews @tcgilbert @forstisabella

forstisabella
forstisabella previously approved these changes Aug 22, 2024
View reviewed changes
tcgilbert
tcgilbert suggested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to these changes, can you update the folder name to "actions-topsort".

  • topsort/index.md -> actions-topsort/index.md

This needs to be the same as the slug for your destination

@agustinespildora @tcgilbert
move section
62242c2 
Co-authored-by: Thomas Gilbert <[email protected]>
agustinespildora and others added 4 commits August 23, 2024 09:02
@agustinespildora @tcgilbert
remove automated status
8c25b29 
Co-authored-by: Thomas Gilbert <[email protected]>
@agustinespildora @tcgilbert
move section
71da8aa 
Co-authored-by: Thomas Gilbert <[email protected]>
@agustinespildora
changed folder name to destination slug (#5)
5507716 
changed folder name and fix code block
@agustinespildora
lint fix (#6)
85a0e38 
fix lint
@agustinespildora
Copy link
Contributor Author

In addition to these changes, can you update the folder name to "actions-topsort".

  • topsort/index.md -> actions-topsort/index.md

This needs to be the same as the slug for your destination

Thanks @tcgilbert, changed folder and commited last suggestions.

@tcgilbert
Copy link
Contributor

@agustinespildora thanks for the changes. We have everything on our side to make the integration live.

If you have tested your destination and confirmed it is working as expected, we can get this live on the next docs deployment next week.

@agustinespildora
Copy link
Contributor Author

Hi team! Do you know when is the next deploy?

@forstisabella
Copy link
Contributor

hi @agustinespildora - I'll merge this PR today, and the changes will be live tomorrow after 11AM Pacific time. Thanks!

@forstisabella forstisabella merged commit 04f7194 into segmentio:develop Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forstisabella forstisabella forstisabella approved these changes

+1 more reviewer

@tcgilbert tcgilbert tcgilbert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
new-integration Added a new source or destination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agustinespildora @tcgilbert @forstisabella