Skip to content

Conversation

mayur-pitale
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

@mayur-pitale mayur-pitale requested a review from a team as a code owner November 20, 2024 22:38
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@stayseesong
Copy link
Contributor

@mayur-pitale is this still being drafted or is it ready for review?

@mayur-pitale
Copy link
Contributor Author

mayur-pitale commented Dec 3, 2024

@mayur-pitale is this still being drafted or is it ready for review?

@stayseesong - still being drafted, I'll push by EoD

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@mayur-pitale
Copy link
Contributor Author

@stayseesong - ready for review

@stayseesong stayseesong requested a review from tcgilbert December 4, 2024 00:18
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

tcgilbert
tcgilbert previously approved these changes Dec 4, 2024

### Actions
Build your own Mappings. The following action is supported:
- [Sync to S3](#sync-to-s3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayur-pitale sorry, one last thing, where is this linking to? there is no #syn-to-s3 section on this page

@stayseesong
Copy link
Contributor

@mayur-pitale also wanted to confirm, this integration is in beta?

@mayur-pitale
Copy link
Contributor Author

@mayur-pitale also wanted to confirm, this integration is in beta?

@stayseesong - I removed the Actions section. I believe including the actions-fields.html should include any actions connected to this destination, correct?

@mayur-pitale
Copy link
Contributor Author

@mayur-pitale also wanted to confirm, this integration is in beta?

@stayseesong - Yes, it is currently in private beta

@stayseesong
Copy link
Contributor

correct, adding actions-fields.html includes any actions connected to the destination.

But is this integration in beta?

@mayur-pitale
Copy link
Contributor Author

correct, adding actions-fields.html includes any actions connected to the destination.

But is this integration in beta?

@stayseesong - Yes it is in private beta

@stayseesong stayseesong added the new-integration Added a new source or destination label Dec 5, 2024
@stayseesong stayseesong merged commit f180074 into segmentio:develop Dec 5, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration Added a new source or destination

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants